Support private key as authentication vs file? about vonage-node-sdk

[cbetta]

@leggetter check, I just figured that out. I was going to suggest similar behaviour for the node library indeed.

[tjlytle]

@cbetta I missed specifying this in the client spec (will add) but we ran into a similar conversation around the python library. I'll be updating the spec to read that the client libraries must accept the key as a string, and may provide a way to pass a filename. Reasoning is the former is possible regardless of how you store the key, the latter dictates storage that may be difficult or impossible depending on how you deploy your application.

[leggetter]

Node supports Buffer or a string path at present.

[cbetta]

@leggetter yet it does not support this:

var Nexmo = require('nexmo');

var nexmo = new Nexmo({
    apiKey: 'key',
    apiSecret: 'secret',
});


nexmo.app.create(
  'First Voice App',
  'voice',
  'http://example.com/answer',
  'http://example.com/event',
  {},
  function(err, res) {
    var appId = res.id;
    var privateKey = res.keys.private_key;

    nexmo = new Nexmo({
      apiKey: 'key',
      apiSecret: 'secret',
      applicationId: appId,
      privateKey: privateKey
    });
  }
);

What am I missing?

[leggetter]

It doesn't support the key being passed as a string. Just:

1. String - path to file
2. Buffer - contents of key loaded into a buffer

The suggestion elsewhere has been to check the start of the string to see if it's the key. See https://github.com/Nexmo/nexmo-python/issues/12

[leggetter]

Closed via #80