Importing @vonage/server-sdk causes TypeScript errors because of incorrect imports in @vonage/voice about vonage-node-sdk

[manchuck]

Quick update for you @duckdotapk There is a current initiative to add documentation to the code. This is requiring fixes in Typescript which will no longer require us to need to have skipLibCheck enabled.

[manchuck]

@duckdotapk Ahh, that would do it. For now, skipLibCheck is set to true due to some conflicts when bucket files were added. We had code samples that suggested importing like @vonage/voice/dist/classes/NCCO/Conversation. Since that is not ideal (as you would need to know the whole structure of each package), bucket files were created. I had some concerns that developers were still using that older method of importing and wanted to deprecate the older way of importing. There were many cases where we had types, interfaces and classes all named the same when they should have been made unique. We will be going through and resolving these conflicts which will allow us to turn off skipLibCheck

[manchuck]

@duckdotapk I am wrapping up this work with #872 As it is the end of the year, wont be released until early Jan. I apologize that we were not able to get this out sooner for you. I hope you have a happy holiday and I will provide an update once I get back from the holidays

[duckdotapk]

@manchuck Awesome! Thank you for your hard work, Hot Dog Hat Man.

[manchuck]

hmm maybe it does not recognize ts as a valid render. Or I'm building out the @example tag incorrectly. I'll have to play around with it. Thanks for the screen shot

[manchuck]

@duckdotapk I cannot reproduce with version of server SDK (3.7.1) or with the version you are reporting. Can you share your tsconfig.json so I can take a look to see if there is something wonky with it?

[duckdotapk]

@manchuck It seems to be related to me having skipLibCheck explicitly set to false in my tsconfig.json.

If I set it to true, the errors go away. I don't quite remember why I set it like this, though, and I think there might still be a problem in the SDK regardless? I'm not sure.

[duckdotapk]

Btw, this is with 3.7.2 installed now.

[duckdotapk]

Fantastic, thanks for the update. :)

[duckdotapk]

That's awesome, I appreciate it a lot! No worries about the time frame and I hope you have a happy holiday, too!

[manchuck]

This should be resolved now that v3.12.0 has been released

[manchuck]

🌭

[manchuck]

Side question: How are the doc blocks looking in your IDE of choice?

[duckdotapk]

@manchuck A little bit broken looking in WebStorm 2023.3.1 though I'm not sure if that's your fault or theirs.