vnma / restaurant Goto Github PK

You have done most part of the homework, really appreciate your work

Goals of this homework:

• Learn how to define root path and custom paths. Use _path methods in controller and view files
• Use ActiveRecord querying with .where
• Create multiple ActiveRecord models with different types of columns
• Sort items by using ActiveRecord's .order method (reference here)
• Use ActionController's Flash to display success or failure notices (reference here)

Great stuffs:

• You look confident using where, really awesome stuffs
• You also look confident using belongs_to and has_many
• Very good use of validation, nice job man. You also know how to use numericality and :length => { :minimum => 10, :maximum => 15 }
• Nice email validation too validates_format_of :email, :with => /\A([^@\s]+)@((?:[-a-z0-9]+\.)+[a-z]{2,})\z/i
• Good use of flash
• Using before_save is great
• You have created number of functions in model, this keeps the code small, good job man <3
• Keep expore ruby functional stuffs man like this one collect and sort_by, very nice to see them
• Nice features in cart_show page
• You also know how to do ajax and respond_to :js

Suggestions:

• I suggest you spend time on optional issues, they will really bring you to the next levels
• Instead of sort_by you can use order method of ActiveRecord, it brings more performance and scability, check it out
• I think you should spend sometime update your README