vjanssens / woocommerce-dropbox Goto Github PK

Hello Vadiem,
first of all very nice plugin and very useful, just the right thing i was looking for.
After instalation and testing it runs perfectly for "Downloadable Simple Products".
As i set up "Downloadable Variations" instead (http://docs.woothemes.com/document/digitaldownloadable-product-handling/) unfortunately the "Dropbox upload button" had no function at all. After a few tries to set up again, sometimes it has its function and the drobbox window opens up and i coult choose my download file. Then i could save the product settings. But the download link was never functioning. When i then went back into the product settings the chosen download link was not there any more, it was obviously not saved.
Perhaps you have an idea to solve this.
(i am on WP 4.1.1 and Woocommerce 2.3.7)
Fred

As reported in the support forum for this plugin, downloads do not work for files with filenames greater than 36 characters. This is because this plugin is improperly setting the value of the download's hidden file hash field when selecting a file. The problem is this line, in assets/js/woocommerce-dropbox.js:

fileRow.find('.file_name > input').val(file.name).change();

This line fills all inputs in the .file_name element, but there are two inputs, the _wc_file_names[] input, which is correct, and a hidden input, _wc_file_hashes[], which is supposed to be blank for new downloads, and is used for the unique ID for the download generated by the server.

This causes problems when WooCommerce attempts to create download permissions, because it uses this field as the download ID, and the database column won't permit more than 36 characters for an ID, so WooCommerce fails to grant download permissions for these downloads.

The solution is to simply only set the file name in the appropriate field:

fileRow.find('input[name="_wc_file_names[]"]').val(file.name).change();

I love your useful plugin and almost my clients are using it. However, recently it doesn't work anymore. Do you have any plans or guides for contributors can create PR and help to maintain this wonderful plugin?

Hi,

I have zip that i store in dropbox and then link yo your extension.

if i use the url link of dropbox my zip is ok.
if i use the link generated by woocommerce dropbox, my zip is corrupted ?

What can i do ?

Thanks