vizuaalog / bulmajs-docs Goto Github PK

Clicking the first 'toggle modal' button correctly opens the modal but also removes the button, which it shouldn't do.

VizuaaLOG/BulmaJS#87

Where I can see the source code of the site. I will gladly help.

Chrome 76.0.3809.100, (64 бит)

VizuaaLOG/BulmaJS#102

The current documentation has examples of some features. However, having as many examples as possible for the various features would be ideal.

VizuaaLOG/BulmaJS#94

Related issue

https://bulmajs.tomerbe.co.uk/docs/0.10/1-getting-started/2-installation/

import Navbar from '@vizuaalog/bulmajs/src/plugins/Navbar';

Should be

import Navbar from '@vizuaalog/bulmajs/src/plugins/navbar';

Related issue

New methods

Is your feature request related to a problem? Please describe.
It seems like modals can be closed with the esc key, but the same does not apply to alert.
I'm using alert as an alternative to window.confirm(), and have found this to be unintuitive as compared to the native confirm API.

Describe the solution you'd like
It would be great if alerts could also be closed by pressing the esc key.

Additional context
Alerts are not always used as confirmation, so maybe adding an option like this would be more appropriate:

Alert.create({
  title: 'Are you sure?',
  body: 'Please confirm',
  confirm: {
    label: 'Yes',
    close: true,
    onClick: function() {...}
  },
  cancel: {
    label: 'Cancel',
    close: true,
    escKey: true,
    destroy: true
  }
})

Versions
BulmaJS: Version used in documentation at: https://bulmajs.tomerbe.co.uk/docs/master/2-core-components/modal/
Browser: Opera Version:68.0.3618.173, Firefox version 77.0.1 (64-bit)
Operating system: Windows 10

Describe the bug
The developer console outputs the following error when attempting to show the modal in Example number 2:
Uncaught Error: A plugin requires a root and/or a parent. at Modal.Plugin (plugin.js:59) at new Modal (modal.js:72) at Function.Bulma.create (core.js:78) at HTMLButtonElement.<anonymous> ((index):249)

To Reproduce
Steps to reproduce the behavior:

1. Go to https://bulmajs.tomerbe.co.uk/docs/master/2-core-components/modal/#html
2. Click on 'Toggle Modal'
3. Use 'Inspect Element' to open console
4. See error as described above

Expected behavior
The example modal should be toggled

Screenshots

Currently, on some devices the version dropdown can look out of place. Replace it with a Bulma dropdown to make it blend in more with the rest of the site.

VizuaaLOG/BulmaJS#107

The latest jigsaw version uses Laravel's new Blade Components 😍 . Look at updating to latest and backporting changes to previous versions.

When the docs are ready for publishing, a deploy script is needed. This will handle:

• Building the documentation using the Jigsaw build tools, this includes compiling all documentation assets.
• Indexing for search (if this is required, based on the choices from #1).
• Git pulling all relevant past and current versions of BulmaJS into the assets folder. So that old versions use the correct version of BulmaJS.
• Pushing to the hosting platform, whether this is still Github pages or another provider.

"there" should be "their"

Sentence:
You can add the is-hover class to show/hide the dropdown when the user places there mouse over the button.

Location:
https://vizuaalog.github.io/BulmaJS/docs/0.9/dropdown

It can be quite tedious doing the tasks required for prepping a new major docs release. Would be nice to be able to automate the following:

• Updating the relevant config files, adding the new version to the array, updating the released version, and updating the version of the docs
• Copying the master docs folder into a folder for the new version
• Deploying to the docs server

This could be implemented via Algolia's documentation search. Or via another method.

Related issue

VizuaaLOG/BulmaJS#95