vittorioromeo / vrm_core

Lightweight C++14 utility library. (Modernized, stripped and cleaned-up version of SSVUtils.)

vrm_core

General-purpose C++17 utility library.

Intended usage (quick start)

1. Add this repository, SuperV1234/vrm_cmake and SuperV1234/vrm_pp as submodules of your project, as subfolders in your_project/extlibs/:

   git submodule add   https://github.com/SuperV1234/vrm_cmake.git   your_project/extlibs/vrm_cmake
   git submodule add   https://github.com/SuperV1234/vrm_pp.git      your_project/extlibs/vrm_pp
   git submodule add   https://github.com/SuperV1234/vrm_core.git    your_project/extlibs/vrm_core

2. Include vrm_cmake in your project's CMakeLists.txt and look for the vrm_pp and vrm_core extlibs:

   # Include `vrm_cmake`:
   list(APPEND CMAKE_MODULE_PATH "${CMAKE_SOURCE_DIR}/extlibs/vrm_cmake/cmake/")
   include(vrm_cmake)
   
   # Find `vrm_pp` and `vrm_core`:
   vrm_cmake_find_extlib(vrm_pp)
   vrm_cmake_find_extlib(vrm_core)

(Altenatively, only add vrm_core and vrm_cmake as submodules, and recursively pull submodules to let vrm_core find vrm_pp.)

vrm_core's Issues

FWD implementation

First of all I wanted to say impressive talk today at CPPCon for static_if and static_for -- excellent ideas and implementations. During the talk though I noticed something that might be worth bringing up.

In the implementation of the FWD macro there are a couple of possible errors

Currently it's written as:

#define VRM_CORE_FWD(...) ::std::forward<decltype(__VA_ARGS__)>(__VA_ARGS__)

Unless this std::forward is a custom implementation, there are two things here that may lead to more cryptic errors.

1. the template type<decltype(__VA_ARGS__)> will only deduce the type of the last arg in the set, because it would expand with the comma operator. For example, decltype(1,1.0) only deduces double and not int,double.
2. std::forward in the standard only takes one argument, making the __VA_ARGS__ part of this likely unnecessary.

The reason I bring this up is because something like FWD(1,1.0) will essentially translate into a call of:
::std::forward<double>( 1, 1.0 ) -- and this leads to strange compiler messages.
It may be worth changing to just FWD(x) instead.

vrm::core::delegate usage examples

Hi,

are there any usage examples on vrm::core::delegate.
I see it's experimental. Can one use it? (And: does one need it? :) Or put another way: for what would one use it?)

Thanks.

PS: I came here via jamboree/CxxFunctionBenchmark#10 (comment)