virtualmin / virtualmin-git Goto Github PK
View Code? Open in Web Editor NEWVirtualmin plugin to manage git repository creation and hosting for domains
License: GNU General Public License v3.0
Virtualmin plugin to manage git repository creation and hosting for domains
License: GNU General Public License v3.0
Testing the beta install on Debian 11.
When enabling git for a domain or importing a domain with git, apache2 won’t (re)start.
Jul 12 12:02:54 cloud11.website.com apachectl[11746]: AH00526: Syntax error on line 46 of /etc/apache2/sites-enabled/website.com.conf:
Jul 12 12:02:54 cloud11.website.com apachectl[11746]: Invalid command 'DAV', perhaps misspelled or defined by a module not included in the se>
Jul 12 12:02:54 cloud11.website.com apachectl[11743]: Action 'start' failed.
Jul 12 12:02:54 cloud11.website.com apachectl[11743]: The Apache error log may have more information.
Jul 12 12:02:54 cloud11.website.com systemd[1]: apache2.service: Control process exited, code=exited, status=1/FAILURE
The problem is that the git module adds DAV to the apache config file:
DAV on
Which causes the error at apache2 startup, because mod_dav and mod_dav_fs are not enabled by default.
I understood that DAV is no longer supported. If that is the case enabling git should also no longer add DAV lines to the config files. And git should only be supported through ssh and no longer through DAV. Which also means the git example commands shown should be updated as they right now tell users how to use git through DAV.
As an alternative it might be a good idea to check if mod_dav and mod_davfs are enabled. It looks like there is a check for mod_rewrite. If there was another check for mod_dav and mod_davfs and an exception is thrown when they are not enabled, then at least apache2 would restart properly.
In this line:
my ($locstart, $locend) =
&find_git_repo_lines($lref, $virt->{'line'}, $virt->{'eline'}, $rep);
https://github.com/virtualmin/virtualmin-git/blob/master/virtualmin-git-lib.pl#L291
$rep is not defined, and seems to be mandatory when calling find_git_repo_lines. I'm not sure how to get that data into that function, so not sure how to fix it.
Jamie, is this expected to have an error (Failed to modify server : Git cannot be enabled unless a website is) with Nginx or we should add virtualmin-nginx as allowed dependency?
If $ver contains more than one dot, the numeric comparison fails.
virtualmin-git/virtualmin-git-lib.pl
Line 128 in 647c407
I get the following message when I try to delete a user:
Failed to delete users : virtualmin-git::mailbox_delete failed : Can't use string ("first_repo") as a HASH ref while "strict refs" in use at /usr/share/webmin/virtualmin-git/virtualmin-git-lib.pl line 211.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google ❤️ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.