The laravel-p-pdo-via-oci8 from vincentshiqi

laravel-p-pdo-via-oci8's People

Contributors

Watchers

laravel-p-pdo-via-oci8's Issues

Generated pseudo named parameter should be 1-based indexed

I think there is a problem here:

laravel-p-pdo-via-oci8/src/Pdo/Oci8.php

Lines 103 to 109 in 748857d

    
           if ($this->isNamedParameterable($statement)) { 
        
               // Replace ? with a pseudo named parameter 
        
               $parameter    = 0; 
        
               $statement = preg_replace_callback('/(?:\'[^\']*\')(*SKIP)(*F)|\?/', function () use (&$parameter) { 
        
                   return ':p' . $parameter++; 
        
               }, $statement); 
        
           }

At least on Doctrine DBAL, when ? placeholders are replaced by pseudo named parameters, they are 1-based indexed (p1, p2, ...):

https://github.com/doctrine/dbal/blob/90f79c8b39fa451264537440ead0fe1ab1c751b8/lib/Doctrine/DBAL/Connection.php#L1535

This library is generating 0-indexed pseudo named parameters which can cause errors (It's indeed causing errors to me) when used.

Recommend Projects

React

A declarative, efficient, and flexible JavaScript library for building user interfaces.

Vue.js

🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

Typescript

TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

TensorFlow

An Open Source Machine Learning Framework for Everyone

Django

The Web framework for perfectionists with deadlines.

Laravel

A PHP framework for web artisans

D3

Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

javascript

JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

web

Some thing interesting about web. New door for the world.

server

A server is a program made to process requests and deliver data to clients.

Machine learning

Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

Visualization

Some thing interesting about visualization, use data art

Game

Some thing interesting about game, make everyone happy.

Recommend Org

Facebook

We are working to build community through open source technology. NB: members must have two-factor auth.

Microsoft

Open source projects and samples from Microsoft.

Google

Google ❤️ Open Source for everyone.

Alibaba

Alibaba Open Source for everyone

D3

Data-Driven Documents codes.

Tencent

China tencent open source team.

	if ($this->isNamedParameterable($statement)) {
	// Replace ? with a pseudo named parameter
	$parameter = 0;
	$statement = preg_replace_callback('/(?:\'[^\']\')(SKIP)(*F)\|\?/', function () use (&$parameter) {
	return ':p' . $parameter++;
	}, $statement);
	}

vincentshiqi / laravel-p-pdo-via-oci8 Goto Github PK