Code Errors (two) about viewtouch

[GeneMosher]

Thanks for the prompt code repair, NeroBurner ! I made a clean start of the /usr/viewtouch/dat directory and was able to determine that the first of the two Code Errors I made mention of here seems to be a file corruption issue. I intend to issue a new microSD image soon to rectify this problem.

[NeroBurner]

Can't reproduce segfault 1

---

Segfault 2 is because Page 13 has no last label entry and my Str class doesn't like nullptr as argument to Set(const char*). What is the expected behavior on this page for the last form? I would either set the label to an empty string, then the input field is visible, but has no label on the left (see screenshot below). Or I could disable the form in this case and there would be no last entry visible

The line with the segfault:

viewtouch/zone/phrase_zone.cc

Line 73 in 4404676

f->label.Set(PhraseData[idx].text);

f->label.Set(PhraseData[idx].text);

PhraseData[idx].text is a nullptr

[NeroBurner]

I did some more digging for the second segfault: I recommend to update the PhraseData for this page 13 by removing the following line:

viewtouch/main/locale.cc

Line 243 in 4404676

{12, FamilyName[31]},

The FamilyName[31] entry is a reference to NULL, (last entry of the following block):

viewtouch/main/labels.cc

Lines 297 to 307 in 4404676

	const genericChar* FamilyName[] = {
	"A La Carte", "Appetizer", "Breakfast Entree",
	"Burger", "Lunch Entree", "Light Dinner",
	"Dinner Entree", "Soup", "Child Menu",
	"Dessert", "Salad", "Sandwich", "Seafood",
	"Side Order", "Pizza", "Specialty", "Specialty Entree",
	"Banquet", "Bakery",
	"Beverage", "Beer", "Bottled Beer",
	"Wine", "Bottled Wine", "Alcohol", "Cocktail",
	"Malt Beverage", "Modifier", "Reorder",
	"Merchandise", "Room", NULL};

[NeroBurner]

Page 13 of 16 with labels.cc updated

[NeroBurner]

reopen for the first segfault in "Receipts Balance" not yet fixed