Comments (3)
To me this change looks 100% correct.
Regarding the anyOf
:
- the
hull.Transformation.Pattern
covers all the_HT
variants and_HULL_TRANSFORMATION_
prefixed strings so you can put a transformation in place of an actual concrete value. - the other part of the
anyOf
(here"type": "string"
) covers all allowed concrete values - which in this case should be the enum values as stated. According to JSON schema theenum
values can be of any type but if we put in the string values here this should make an additional"type": "string"
next to theenum
spec obsolete I think.
Due to the huge amount of data and initial work on the values.schema.json
it is possible that similar (hopefully non-major) issues may be lurking there too.
Thanks @matthias4217 for your contribution! The tests have been successful against all Helm versions (note there is one "failing" test vidispine.hull.test
but this is due to a GitHub issue and can be ignored for now - still need a way to fix this inconvenience).
Will create a batch of new releases with this fix. FYI the strategy I followed for this is to merge the changes for new releases including documentation and chart version bump into last three branches named fixes-1.xx
. Then I open PRs to merge these to the corresponding release-1.xx
branches hereby running all gated tests. After merges, the actual releases are created (on the Azure Dev Ops side at the moment) and lastly the main branch is updated from the latest release-1.xx
branch to match the latest charts state.
from hull.
That would for sure save me some effort so feel free if you want to but - at least for now - I am fine with someone forking and merging to main and me doing the rest. At the moment the additional effort for me is reasonable.
Btw fixed that failing AzureDevOps (dummy) test so they all get green on PRs now 👍
Also added a test to verify imagePullRequests can be used in the way you intended.
Releases:
from hull.
Okay thanks ! So, next time I open a pull request, should I do it against the fixes-1.xx
branches instead of main
?
from hull.
Related Issues (20)
- hostNetwork? HOT 3
- Bug: Ingress with TLS HOT 4
- Quoted values transformed to scientific notation number HOT 4
- Using transformations in objects' names HOT 2
- Empty list in hull.util.transformation.include HOT 8
- Generating properties with transformations HOT 2
- Using transformations in hull.objects.secret.*.data.*.inline HOT 13
- Something is wrong when using a transformation in hull.objects.ingress.*.tls.*.hosts HOT 3
- The hull.util.transformation.makefullname transformation and and the staticName parameter HOT 9
- Creating non-opaque Secrets HOT 6
- hull.util.transformation.get converts a string to an integer HOT 3
- Empty fields in rendered template HOT 5
- Accessing the global context from an interpolation placeholder HOT 7
- Is there an idiomatic way to access Chart and Release objects HOT 7
- Add more single valued functions to `_HT*` transformations HOT 1
- Add `sharedContainers` feature
- Enable array access in `_HT*` HOT 1
- Default security settings
- [question] Is it possible to create ConfigMap from a directory using glob pattern ? HOT 20
- Cronjob jobspec not mapping several fields HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hull.