Coder Social home page Coder Social logo

Comments (3)

gre9ory avatar gre9ory commented on June 24, 2024 1

To me this change looks 100% correct.

Regarding the anyOf:

  • the hull.Transformation.Pattern covers all the _HT variants and _HULL_TRANSFORMATION_ prefixed strings so you can put a transformation in place of an actual concrete value.
  • the other part of the anyOf (here "type": "string") covers all allowed concrete values - which in this case should be the enum values as stated. According to JSON schema the enum values can be of any type but if we put in the string values here this should make an additional "type": "string" next to the enum spec obsolete I think.

Due to the huge amount of data and initial work on the values.schema.json it is possible that similar (hopefully non-major) issues may be lurking there too.

Thanks @matthias4217 for your contribution! The tests have been successful against all Helm versions (note there is one "failing" test vidispine.hull.test but this is due to a GitHub issue and can be ignored for now - still need a way to fix this inconvenience).

Will create a batch of new releases with this fix. FYI the strategy I followed for this is to merge the changes for new releases including documentation and chart version bump into last three branches named fixes-1.xx. Then I open PRs to merge these to the corresponding release-1.xx branches hereby running all gated tests. After merges, the actual releases are created (on the Azure Dev Ops side at the moment) and lastly the main branch is updated from the latest release-1.xx branch to match the latest charts state.

from hull.

gre9ory avatar gre9ory commented on June 24, 2024 1

That would for sure save me some effort so feel free if you want to but - at least for now - I am fine with someone forking and merging to main and me doing the rest. At the moment the additional effort for me is reasonable.

Btw fixed that failing AzureDevOps (dummy) test so they all get green on PRs now 👍
Also added a test to verify imagePullRequests can be used in the way you intended.

Releases:

1.23.15
1.24.10
1.25.9

from hull.

matthias4217 avatar matthias4217 commented on June 24, 2024

Okay thanks ! So, next time I open a pull request, should I do it against the fixes-1.xx branches instead of main ?

from hull.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.