Comments (6)
Starting from releases:
it is now possible to set the type
of secrets.
Thank you!
from hull.
@khmarochos
Closing this issue hoping the solution provided works for you. Otherwise feel free to restart the discussion here.
Thank you for the participation!
from hull.
I had found couple of times that it would be appropriate to be able to create other secrets such as token secrets as well. Then I always managed to dodge the scenarios that would require implementing it so skipped it. For the docker configs of course you can use the registry
object type which I would recommend since the set of features around it should simplify image handling in general.
But yeah, of course I would welcome your PR for full configurability.
From https://kubernetes.io/docs/concepts/configuration/secret/ I get that the type may even be freely defined (didn't know that yet :) ) so it should just be possible to set any string value for the type. Implementationwise it should be sufficient to remove the hard-coding of type: Opaque
. Default if not provided should still be type: Opaque
of course. The JSON schema for io.k8s.api.core.v1.Secret
already allows to specify the type
so no changes to the schema should be required - actually a bug since the hard-coding and an additional free specification of kind
would have caused problems likely. There are some additional validations applied to some types the Kubernetes docs say but I don't feel it is something that has an impact on a first implementation now. These are just my thoughts on implementation, feel free to provide yours.
For the PR it would be good if you add your code to the fixes-1.29
branch and open a PR to merge to release-1.29
. If everything is looking good we can do the same for fixes-1.27
and fixes-1.28
and also merge fixes-1.29
to main last.
Thank you!
from hull.
Hello!
I'm not sure that my solution is correct. Perhaps I just don't know some architectural aspects of HULL, so my patch might turn out to be too straightforward.
And I'm very sorry for the newline character in the end of the template file. I didn't notice it before to make a PR. :-(
from hull.
Hooray! Thank you for the update!
from hull.
Closing
from hull.
Related Issues (20)
- Override `namespace` for objects HOT 8
- hostNetwork? HOT 3
- Bug: Ingress with TLS HOT 4
- Quoted values transformed to scientific notation number HOT 4
- Using transformations in objects' names HOT 2
- Empty list in hull.util.transformation.include HOT 8
- Generating properties with transformations HOT 2
- Using transformations in hull.objects.secret.*.data.*.inline HOT 13
- Something is wrong when using a transformation in hull.objects.ingress.*.tls.*.hosts HOT 3
- The hull.util.transformation.makefullname transformation and and the staticName parameter HOT 9
- hull.util.transformation.get converts a string to an integer HOT 3
- Empty fields in rendered template HOT 5
- Accessing the global context from an interpolation placeholder HOT 7
- Is there an idiomatic way to access Chart and Release objects HOT 7
- Add more single valued functions to `_HT*` transformations HOT 1
- Add `sharedContainers` feature
- Enable array access in `_HT*` HOT 1
- Default security settings
- [question] Is it possible to create ConfigMap from a directory using glob pattern ? HOT 20
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hull.