victor-falcon / laravel-task

A simple way to trigger tasks in a clean and simple way

Hi 👋, I'm Víctor

A passionate developer from Madrid, Spain.

📫 You can reach me on [email protected] or on twitter

laravel-task's Issues

🐛 Ide helper information fails when we add a primitive type to the task constructor

To replicate just create a task with a primitive in the constructor:

final class GetUser extends Task
{
    use Taskable;

    private string $email;

    public function __construct(string $email)
    {
        $this->email = $email;
    }

    public function handle(): User
    {
        return User::whereEmail($this->email)->firstOrFail();
    }
}

And run artisan task:ide-help.

Output:

❯ ./vessel artisan task:ide-help

   Illuminate\Contracts\Container\BindingResolutionException 

  Unresolvable dependency resolving [Parameter #0 [ <required> string $email ]] in class App\Tasks\User\GetUser

  at vendor/laravel/framework/src/Illuminate/Container/Container.php:1053
    1049▕     protected function unresolvablePrimitive(ReflectionParameter $parameter)
    1050▕     {
    1051▕         $message = "Unresolvable dependency resolving [$parameter] in class {$parameter->getDeclaringClass()->getName()}";
    1052▕ 
  ➜ 1053▕         throw new BindingResolutionException($message);
    1054▕     }
    1055▕ 
    1056▕     /**
    1057▕      * Register a new before resolving callback for all types.

      +22 vendor frames 
  23  artisan:37
      Illuminate\Foundation\Console\Kernel::handle()

what makes this package better than laravel itself?

hi,

can you please explain whats the benefit of this package is beside the build-in tools laravel already offers?
I don´t really understand this.

thanks a lot,
micha