viasat-location-tracking / rtls_server Goto Github PK

Is your feature request related to a problem? Please describe.
The map data is currently fetched by each client in the form of individual HTTP Get requests several times per second. This clutters up the network request log in the browser and also is not a very clean way of implementing constantly changing data.

Describe the solution you'd like
Sending the data via persistent websockets using Channels would be a cleaner way to get the map data from the server to the client. It would also allow for continuously updating maps, rather than maps that update every x milliseconds (based on the setInterval() parameters for the AJAX request.)

Describe alternatives you've considered
The alternative would be the current solution, which involves each client polling the server every x milliseconds for new map data.

Describe the bug
On the mainline page, if you try to send a tag to the clinic that never got a serial number assignment on the Tag Assignment page, the AJAX request will return a 500 error (visible in the browser console). These tags show up as "S/N not found" in the "Send to Clinic" dropdown.

To Reproduce

1. Go to the mainline page
2. Place some tags in a zone (in the real world), and select that zone using the dropdown on the mainline page
3. Click the "Send to Clinic" button
4. Select a tag without a serial number assigned (shows up as "S/N not found" in the dropdown)
5. Press "Send to Clinic"
6. Observe the 500 error in the browser console. Additionally, the modal doesn't close.

Expected behavior
The user should either:
A. Receive an error message stating that the selected tag needs to be assigned a serial number first, or
B. Not be able to initiate such a request for a non-assigned tag in the first place, or
C. Be able to send the tag anyway, possibly with a warning that the tag is not assigned.