versx / whmgr

Discord notification system that works with RealDeviceMap and reports Pokemon, Raids, Eggs, Quests, Pokestop Lures, Team Rocket Invasions, Gym team changes, and Weather as embed messages. Discord users can also subscribe to custom Pokemon, Raid, Quest, Team Rocket Invasion, and Pokestop Lure notifications via direct message (DM) with predefined requirements.

Hi there 👋

I'm versx, I like to code.

Languages:

Skills:

Internet of Things:

Integrated Development Environments:

Storage:

Current Main Project:

whmgr's Issues

Support for subbing to Mons by Weight

Feature request for whmgr/ whmgr-ui
Allow users to sub to Mons by weight. So they can get their big karps with weight over 13.13kg

[Bug] Webhooks can sometimes cause thread safety-related exceptions

I was noticing after a user subscribed to PvP notifications that the bot was throwing a good amount of exceptions from the ParsePokemon method of HttpServer:

1:03 AM [ERROR] [HTTP] System.IndexOutOfRangeException: Index was outside the bounds of the array.
   at System.Collections.Generic.Dictionary`2.TryInsert(TKey key, TValue value, InsertionBehavior behavior)
   at System.Collections.Generic.Dictionary`2.Add(TKey key, TValue value)
   at WhMgr.Net.HttpServer.ParsePokemon(Object message) in /home/whmgr/WhMgr/src/Net/HttpServer.cs:line 350

This made my log file get massive overnight.

The only time an IndexOutOfRangeException can be thrown from Dictionary<,>.Add is if more than one thread is writing to it at once, or a thread tries to write to it while another is reading. This can be solved with a lock(...) { } block around the relevant access to these dictionaries while processing webhooks.

[Feature] EX raid subscriptions

Maybe..

[Feature] Raid Egg subscriptions

Allow for subscriptions for raid eggs.

[Feature] One big tile picture for all nests.

Instead of posting pokemon nests one by one, WhMgr can post one big tile picture with the pokemon nests on it.

Invasion Subscription by Pokestop

Subscribe to invasions by individual Pokestop instead of just reward (or potentially type)

[Feature] Filter Quest alarms by Pokemon form(s)

[Feature] Filter Raids by costume(s)

[Feature] Mega Raid Subscriptions

Allow the option to subscribe to mega Pokemon raids not just any Gengar raid.

Fix Weather Staticmap

[Feature Request] Allow custom embed colors via config

[Feature Request] Customize DTS Address for Google Maps/OSM Nominatim

Duplicate to #68

[Feature] Use Raid Pokemon Costume

Use raid_pokemon_costume value in DTS and possibly raid filter

'.pokeme all 100' doesn't include gen 6+ (hardcoded to 649)

When using something like '.pokeme all 100', it creates subscriptions based on the value of Strings.MaxPokemonIds, which is currently hard coded to 649 in Strings.cs. It therefore doesn't include anything from gen 6+.

List all subscriptions with .info command

List complete subscriptions list for Pokemon

[Feature] Filter Pokemon by costume(s)

[Feature] Allow to specify own address format for Google Maps and Nominatim

Instead using Nominatim API display_name allow user to define own address objects to return from config file.

Example json with data:
https://nominatim.openstreetmap.org/reverse?format=jsonv2&lat=50.6661563&lon=17.926697773752586

Related part in code:

WhMgr/src/Utilities/Utils.cs

Line 126 in 5415f64

return new Location(Convert.ToString(obj.display_name), city ?? unknown, Convert.ToDouble(obj.lat), Convert.ToDouble(obj.lon));

Allow custom alerts.json for user subscriptions

Allow the option to specify an alerts.json for user subscriptions per Discord server instead of the default built in values.

Missing option for nests filtering.

Currently WhMgr don`t support filter for nests and post every possible nest without option to filter by pokemon per hour.

Enable/Disable Subscriptions by Type

Include ability to enable/disable specific types instead of just all or nothing

check yourls

remind you to check yourls

[Bug] Pokemon GO cell_id can sometimes be larger than long.MaxValue

I encountered a System.OverflowException in the testing environment in which I'm testing WhMgr right now because there are Pokestops in our system with a cell_id greater than long.MaxValue, which was causing issues reading Pokestop models from the database. Changing Pokestop.CellId to ulong fixed the issue. I will be submitting a PR to fix this soon; just wanted to file an issue too for the sake of formality.

[Feature] Separate Discord server configs from main config

Separate Discord server configs from main config to slim up the main config.

Pause/Resume by Subscription Type

Currently, pause/resume is only available globally. We should add support for pausing/resuming each type individually - Invasions, Lures, Pokemon, PVP, Raids, Quests, etc.

Switch to EntityFramework

Expand Geofence capabilities to allow non-Alarm geofences to be used for DMs and to support GeoJSON

I am currently helping test out WhMgr on a Discord server I'm a part of as a potential replacement for another bot. While I was setting up a test instance of WhMgr, I was having issues getting any DMs sent even though I could tell that webhooks were being fired on the bot and some of them should have matched my subscriptions. I went through and debugged the WhMgr project so I could step through the notification processing code, and noticed that it was bailing because there were no Geofences loaded despite me having files in the geofences folder. It appears as though Geofences are only loaded if an Alarm references them in its geofence list. I would preferably like to use the DM feature of WhMgr right now without any actual alarms set up.

To me, it would make sense to iterate through the files in the geofences folder at the same time that the Alarms are loaded (in the constructor of WebhookController). It doesn't seem that the geofences for DM notifications are in any way related to Alarm geofences except that geofence files are only loaded if an Alarm mentions them.

I can submit a PR for this if this is an acceptable change to make.

Incorrect 'Weakness' listings for Raid Boss Notifications

Raid Boss Notifications are getting over-populated with Weakness typing. This issue seems consistent across all Pokemon Raid Boss types.

Example:

(Bastiodon is only weak to Fighting, Ground & Water)

Raid Subscription by Gym

Subscriptions for raids should have an option for subscribing by gym that does NOT modify all of your current raid Pokemon subscriptions.

Invasion Subscription by Invasion Type

Subscriptions for invasions should have an option for subscribing by invasion type.

Commands for Modifying Channel Filters

[Bug] Relate Weather cell to all parts of geofence

Check if any part of the weather cell is in any part of geofence and not just the middle of the weather cell that the geofence is in.

[Feature Request] - add iv stats post option

Similar to Chucks bot, a toggle that could post nightly stats of all the hundos "yesterday" in a simple format. Useful as incentive to non donors

Gym posts

WhMgr Gym posts cannot be controlled by any filter. WhMgr post everything regardless of the parameters in the gym filter.

Ability to add multiple pokeme subscriptions for the same pokemon

I'm not sure if this is a feature request or a bug report, but basically, is it possible to make the following work...

note: this is based on a current PR where you don't notify by area and instead do it by location/distance if no city/area is specified.

.pokeme all 100
.pokeme all 100 30 * all

So I would like notifications of all 100iv pokemon within the configured distance of my location and I would like notifications of all 100iv / level 30+ pokemon within all configured cities/areas.
When testing, it seems the 2nd command overwrites the entries in the pokemon db table that were created by the first one.

Switch to Handlebars.NET

Switch to Handlebars.NET to handle staticmap and alert file templates

Unhandled exception - Crash on Empty Shiny Report

Bot started midnight routine, and crashed when the Shiny report was empty.

Trace report:
11:59 PM [DEBUG] [BOT] MIDNIGHT 5/25/2020 11:59:59 PM
11:59 PM [DEBUG] [BOT] Starting automatic quest messages cleanup...
11:59 PM [DEBUG] [BOT] Posting shiny stats for guild MyGuild (#guildid#) in channel #ChannelID#
12:00 AM [DEBUG] [BOT] Unhandled exception caught.
12:00 AM [ERROR] [BOT] System.ArgumentException: Cannot send empty message
at DSharpPlus.Net.DiscordApiClient.d__39.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
at WhMgr.Bot.d__28.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.GetResult()
at WhMgr.Bot.<<-ctor>b__7_0>d.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.AsyncMethodBuilderCore.<>c.b__6_1(Object state)
at System.Threading.QueueUserWorkItemCallback.WaitCallback_Context(Object state)
at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
at System.Threading.QueueUserWorkItemCallback.System.Threading.IThreadPoolWorkItem.ExecuteWorkItem()
at System.Threading.ThreadPoolWorkQueue.Dispatch()
at System.Threading._ThreadPoolWaitCallback.PerformWaitCallback()

Change moderatorIds to moderatorRoleIds

Discord rate limit is hit on startup when multiple "get guild member" calls are made simultaneously

If webhooks come in right after the bot is started, it starts trying to request member info from multiple threads at once while Emojis are still being loaded, causing this:

I have a fix for this already which batches simultaneous requests to the same guild/user combination if there is no cache in place for that user.

[Feature] Filter Raid alarms by form(s)

Separate Raid/Egg Filter Issue

I have two filters one for eggs and one for raid filters. They were reporting to two separate channels before.
.
However the separate filters won't function as expected.
The filter works if Eggs and Raids are both set to true to one channel.
However the egg filter will not work when I separate the filters to two different channels.

I don't know if the manager thinks the messages are duplicated when it isn't.

{
"eggs":
{
"enabled": false,
"min_lvl": 1,
"max_lvl": 4
},
"raids":
{
"enabled": true,
"min_lvl": 1,
"max_lvl": 4,
"pokemon": [],
"type": "Exclude",
"ignoreMissing": false
}
}

{
"eggs":
{
"enabled": true,
"min_lvl": 1,
"max_lvl": 4
},
"raids":
{
"enabled": false,
"min_lvl": 1,
"max_lvl": 4,
"pokemon": [],
"type": "Exclude",
"ignoreMissing": false
}
}

Update PvP subscriptions for level 51

As the title states, PvP subscription calculations need to be updated to go up to level 51 now.

[Feature] Allow Pokemon ID and Name in filters

Filter lures by type

Feature Request to be able to filter Lures by Type enabling the separation of lures into specific channels.

Add clickable location if set to info embed

Need to fix weather filter to align with Protos

Need to fix example weather filter to align with Protos

[Feature Request] Customize PvP DTS

[Feature Change] Enhance feedme/feemenot & role control

Per our discussion in Discord, now that DM subs are entirely independent of 'city roles':

• Cities should be renamed to Areas or Zones (or something else everyone likes, configurable even?) as many of us use roles for different neighborhoods/subareas of the cities we serve and the feedme/feedmenot functions added to it's own WhMgr-UI section.

• Upon donor role loss, any roles given via the bot should be removed (and stored for easy restoral in DB?) along with the DM sub pausing.

Fix Nest polygon Staticmap

[Feature] Filter Pokemon Alarms by form(s)

Missing mega raid embed color

WhMgr/src/Extensions/DiscordExtensions.cs

Line 438 in 642b9df

return DiscordColor.Purple;