vernierst / goio_sdk Goto Github PK

Hi, there are a number of naked "signed" in GSEnsorDDSMem.h. Newer g++ compilers take 'signed' as indeterminant whether it is signed or unsigned. Your code is assuming signed, which is actually not correct C ( although idomatic in the 90's ). Newer compilers complain. Changing all the naked chars to signed chars create any number of other compile errors.

This is g++ 6.3.0.

Errors:
then mv -f ".deps/NonSmartSensorDDSRecs.Tpo" ".deps/NonSmartSensorDDSRecs.Plo"; else rm -f ".deps/NonSmartSensorDDSRecs.Tpo"; exit 1; fi libtool: compile: g++ -DPACKAGE_NAME="" -DPACKAGE_TARNAME="" -DPACKAGE_VERSION="" -DPACKAGE_STRING="" -DPACKAGE_BUGREPORT="" -DPACKAGE_URL="" -DPACKAGE="GoIO" -DVERSION="2.53.0" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=".libs/" -I. -I. -I.. -I../GoIO_cpp/ -I../GoIO_cpp/Linux/ -I../GoIO_DLL/ -fvisibility=hidden -fvisibility-inlines-hidden -DTARGET_OS_LINUX -DLIB_NAMESPACE=GoIO -DUSE_LIB_USB -g -O2 -MT NonSmartSensorDDSRecs.lo -MD -MP -MF .deps/NonSmartSensorDDSRecs.Tpo -c NonSmartSensorDDSRecs.cpp -fPIC -DPIC -o .libs/NonSmartSensorDDSRecs.o NonSmartSensorDDSRecs.cpp:115:1: error: narrowing conversion of ‘-1’ from ‘int’ to ‘unsigned char’ inside { } [-Wnarrowing] }; ^ NonSmartSensorDDSRecs.cpp:148:1: error: narrowing conversion of ‘-1’ from ‘int’ to ‘unsigned char’ inside { } [-Wnarrowing] }; ^ NonSmartSensorDDSRecs.cpp:181:1: error: narrowing conversion of ‘-1’ from ‘int’ to ‘unsigned char’ inside { } [-Wnarrowing] }; ^ NonSmartSensorDDSRecs.cpp:214:1: error: narrowing conversion of ‘-1’ from ‘int’ to ‘unsigned char’ inside { } [-Wnarrowing] }; ^ NonSmartSensorDDSRecs.cpp:214:1: error: narrowing conversion of ‘-1’ from ‘int’ to ‘unsigned char’ inside { } [-Wnarrowing] NonSmartSensorDDSRecs.cpp:247:1: error: narrowing conversion of ‘-1’ from ‘int’ to ‘unsigned char’ inside { } [-Wnarrowing] }; ^ NonSmartSensorDDSRecs.cpp:280:1: error: narrowing conversion of ‘-1’ from ‘int’ to ‘unsigned char’ inside { } [-Wnarrowing]

I tried converting the 'char' to 'signed char' but then other cast errors cropped up. I'll keep hacking, but I thought you'd want this library to compile with modern rasperry pi, it's a pretty popular platform.

I got this by just cloning your library on a raspberry pi and attempting to build it, with current Raspberry Pi debian ( which is stretch ). For the slim cost of an RPI you should be able to fix this.

Thanks

What do you think about creating a NuGet package for distributing the .NET binaries from the GoIO SDK? I'm happy to create and publish the package, but want to get your blessing first.