verifytests / verify.icsharpcode.decompiler Goto Github PK

IL name of nested types is BaseType/NestedType instead of BaseType.NestedType

I just tried to migrate verify tests using this extension, but simply adding the package reference without using anything already crashes all tests:

Fody/NullGuard@master...Verify.ICSharpCode.Decompiler

Now all verify tests fail with
System.MissingMethodException : Method not found: 'Void InnerVerifier..ctor(System.String, VerifyTests.VerifySettings, GetFileConvention)'.

=> https://ci.appveyor.com/project/tom-englert/nullguard

PropertyToDisassemble only disassembles the property definition, which is some what useless:

.property instance valuetype [mscorlib]System.Nullable`1<int32> Property3()
{
	.get instance valuetype [mscorlib]System.Nullable`1<int32> SmokeTest.Testee::get_Property3()
	.set instance void SmokeTest.Testee::set_Property3(valuetype [mscorlib]System.Nullable`1<int32>)
}

It should rather disassemble the getter and the setter method.

Is the feature request related to a problem

Tests occasionally break just because the layout has changed (class/member ordering), while the IL itself is still the same.
see e.g. https://ci.appveyor.com/project/tom-englert/nullguard

see also icsharpcode/ILSpy#2834

Describe the solution

Add option to sort IL output:
icsharpcode/ILSpy#2835

either

• wait until new version of the de-compiler is available
• temporarily copy the source code changes of icsharpcode/ILSpy#2835, so we can have an early release

Describe alternatives considered

Additional context

Should sorted output be the default (breaking change!) with the possibility to opt out, or better opt in (but you need to do it every time)

• System.Reflection.Metadata 7
• Verify 19

it should just work out of the box.

The FindType and FindMethod extensions don't work with generic types or methods.