Coder Social home page Coder Social logo

Comments (4)

joshuajabbour avatar joshuajabbour commented on July 25, 2024

It would be nice to implement this now. It's really biting me because I need my model to have it's own boot method. The way to make it work in the meantime would be to recreate Laravel's bootTraits. Would this work?:

  • Rename current boot to bootRevisionableTrait (removing call to parent::boot()). Then Revisionable just works for newer versions of Laravel.
  • Re-add boot method to the trait with a conditional to see if bootTraits method exists. If not, duplicate the code in Laravel's bootTraits method (or just call bootRevisionableTrait manually if you don't want to duplicate the code). This way, Revisionable will work for older versions of Laravel.

This would still make Revisionable not work properly if the user defines their own boot method in the model, but that isn't a change from the status quo.

It's not ideal, but it wouldn't change anything for users on older versions of Laravel, and for anyone on a new version, they would get the full benefits of bootable traits.

from revisionable.

duellsy avatar duellsy commented on July 25, 2024

Nice, I like the approach. I'm beyond flat out at the moment so won't be able to work on this, but open to pull requests on it

from revisionable.

joshuajabbour avatar joshuajabbour commented on July 25, 2024

Yep, it works fine. I'm doing this manually in my model's boot method. I'll see if I can get a pull request together soon...

public static function bootRevisionableTrait()
{
    // Current code minus `parent::boot()` call.
}

public static function boot()
{
    parent::boot();

    if (! method_exists(get_called_class(), 'bootTraits')) {
        static::bootRevisionableTrait();
    }
}

from revisionable.

duellsy avatar duellsy commented on July 25, 2024

👍

from revisionable.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.