Coder Social home page Coder Social logo

Supporting multiple auth about revisionable HOT 1 OPEN

koushik355 avatar koushik355 commented on June 30, 2024 2
Supporting multiple auth

from revisionable.

Comments (1)

DrowningElysium avatar DrowningElysium commented on June 30, 2024

I would love if the user_id could be replaced with a morph option:

authable_type = \App\Models\User
authable_id = 1
authable_type = \App\Models\Client
authable_id = 1

Would firstly work for any situation. Secondly it would allow for a eager loadable relation, which is currently not the case.
A timeline would need to do n+1 queries to list who did what. Which I think is not desired.

This would be a breaking change. But I do think one for the better.

from revisionable.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.