Use Cartalyst Sentry user id about revisionable

[renege]

make a pr yourself? opensource 👍

[jveldboom]

I would love to. I've just spent most of the morning trying to add a configuration file, but I'm just not able to get it to read. It just returns an empty array.

Here's the steps:

• Create config.php file with /workbench/venturecraft/revisionable/src/config/ with a simple return array('test'=>true);
• Read it with Config::get('package::test');

Any help would be greatly appreciated!

[Jaspur]

Try Config::get('package::file.option'); ? http://laravel.com/docs/packages#package-configuration

[jveldboom]

Thanks for the tip, but that does not seem to make a difference. It still returns an empty array.

[Jaspur]

Like this? #28

[jveldboom]

No, that still did not work for me. The Config::get() still returns an empty array. Could have it something to do with me having the package in the /workbench directory? Your code was exactly what I was trying to do though.

On a side note, I had to add a backslash to the \Config::get()

[Jaspur]

That's indeed because of the naming, when you're having it in your workbench. If you think my code is what you want, the PR should be accepted by @VentureCraft himself, then you'll be able to use it.

[jveldboom]

Thanks!

I would love to help improve this (and other) packages. What is the best way to contribute to an existing package then? Should I just do a normal composer install and modify the source from within the vendors folder?

[Jaspur]

NP.

Yes, that's indeed the easiest way. Then you simply just fork the repo you wanna improve, and add the changes as well over there.

Good luck ;-)

[Antonimo]

Take the user part out of the Model!
I use $this->updated_by to show the author of the last update, so you can use that value for the revisions table also.

edit:
if I use Revisionable I no longer need to save updated_by into my model...

[duellsy]

I've added support now for cartalyst in the lastest commit: 4d9dbb8

[Antonimo]

great! but! Best practice would be not to use another system, especially
User related. let the app handle this, through a repo or something. Im
re-writing the whole thing, so expect a pull ;)

2014-02-20 0:33 GMT+02:00 Chris Duell [email protected]:

I've added support now for cartalyst in the lastest commit: 4d9dbb84d9dbb8

Reply to this email directly or view it on GitHubhttps://github.com//issues/27#issuecomment-35558312
.

[duellsy]

awesome, looking forward to it.... provided it does not use a service provider. As noted in previous comments, since a lot of people are already using this package in production, we can't introduce a mandatory service provider, otherwise it will break a lot of sites that don't have the service provider loaded.

That is, unless you have a way to make it fall back.

Looking forward to seeing what you come up with.