vectorized / multicaller

Efficient multicaller contracts

Hi there 👋 I'm Vectorized

Open-source Solidity repositories I'm currently maintaining:

• Solady Optimized Solidity snippets.
• ERC721A ERC721 implementation optimized for batch minting.
• Multicaller Efficient multicaller contracts.
• DN404 Implementation of a co-joined ERC20 <-> ERC721 pair.

Contact

Direct message or tag me on 𝕏 for the best response times.

multicaller's Issues

Use XDEPLOYER to deploy on multiple chains

Suggestion, why dont use xdeployer to deploy on multiple chains?

Deploy on Base and Blast?

`sender` slot is not always reset

At line 89, the function aggregateWithSender can return early if the data is empty.

multicaller/src/Multicaller.sol

Lines 88 to 89 in b53fdf3

	// Early return if no data.
	if iszero(data.length) { return(returndatasize(), 0x40) }

It happens after the writing in the storage of the sender.

multicaller/src/Multicaller.sol

Lines 83 to 84 in b53fdf3

	// Set the sender slot temporarily for the span of this transaction.
	sstore(returndatasize(), caller())

So in this case the sender is not reset to shl(160, 1).

I would suggest to move the early return above the lines 83-84, or completely remove it.

NB: it saves some gas, because the 3 lines above are not executed then.

Would be great to see this on PulseChain

chains are already in wagmi. happy to find funds if needed for deployments (should be <$1) testnet v4 + mainnet would be awesome
more rpc details:

https://g4mm4.io/
https://pulsechain.com/

`sender` doesn't seem to be forwarded in MulticallerWithSender forge test

I'm working on a router contract that calls MulticallerWithSender in order to "forward" the router's address as msg.sender.

I set up a test to call transfer on an ERC20 to transfer tokens from the router to bob. But I'm seeing an error that the MulticallerWithSender contract has insufficient balance.

For context, I am using a batch permit2 signature then calling aggregateWithSender:

function permitMulticallWithSender(
        address user,
        ISignatureTransfer.PermitBatchTransferFrom memory permit,
        address[] calldata targets,
        bytes[] calldata data,
        uint256[] calldata values,
        bytes memory permitSignature
    ) external {
        if (permitSignature.length != 0) {
            // Use permit to transfer tokens from user to router
            _handlePermitBatch(user, permit, permitSignature);
        }
        // Perform the multicall and refund to the user
        MULTICALLER_WITH_SENDER.aggregateWithSender(targets, data, values);
    }

This is how I'm calling MulticallerEtcher in setUp():

multicaller = MulticallerEtcher.multicaller();
multicallerWithSender = MulticallerEtcher.multicallerWithSender();

Is there any additional setup I need in my test? Any help would be appreciated!

Add contract addresses for Base and Blast to Readme

According to issue #31, contracts were deployed on Base and Blast. The Readme is still missing these contract addresses.