Coder Social home page Coder Social logo

zax's People

Contributors

ch1c0t avatar dependabot[bot] avatar lord-max avatar pavlo-liapin avatar vshpak3 avatar youurayy avatar

Stargazers

avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar

Watchers

avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar

Forkers

chromakode writeon shea256 raj347 ericbahr stormdock stormruby seerdata ch1c0t stormabq stormasm vshpak3

zax's Issues

Should the same client_token request return the same relay_token?

According to the specification(part 3.1, "Alice initiates session),

The same client_token requests should return the same relay_token
until the handshake attempt expires(1m)

For now, it does not seem to be the case. I have created a spec for that. It fails like so:

  1) Alice initiates session /start_session responds with the same relay_token to the same client_token until the handshake attempt expires(1m)
     Failure/Error: expect(first_body).to eq second_body

       expected: "ZfR0K2wBuGZDY6dqXA/DgqEMQzi1WKAml9Cft8lnGO8=\r\n0"
            got: "8Q6DrJt87CAXbRp/6T75qFOSWBu2xPUf0iuNR+dpz+I=\r\n0"

       (compared using ==)

       Diff:
       @@ -1,3 +1,3 @@
       -ZfR0K2wBuGZDY6dqXA/DgqEMQzi1WKAml9Cft8lnGO8=
       +8Q6DrJt87CAXbRp/6T75qFOSWBu2xPUf0iuNR+dpz+I=
        0

It looks like currently a new relay token is created every time, disregarding the handshake attempt expiration.

I think we should either

  1. Remove the note from the specification.
  2. Make the reference implementation adhere to the specification.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.