f1-3-c2p1-colmar-academy's People
f1-3-c2p1-colmar-academy's Issues
missing mobile image
You accidentally are loading the desktop image twice on this part.
https://github.com/VasylenckoSlava/f1-3-c2p1-colmar-academy/blob/master/Colmar/index.html#L94
mobile side scroll issue
You will need to edit this styling in a media query for mobile display to get rid of that side scroll. Usually on mobile you will use width/max-width 100% with no margin.
add this meta tag to your head section
You will want to add this line into your html head section so that your media queries work on all devices:
<meta name="viewport" content="width=device-width, initial-scale=1.0">
https://developer.mozilla.org/en-US/docs/Mozilla/Mobile/Viewport_meta_tag
https://github.com/VasylenckoSlava/f1-3-c2p1-colmar-academy/blob/master/Colmar/index.html#L3
css naming convention
I like the names you are using, but it is more common to use - and _ to separate words in css:
.banner
.banner-img
.banner-text
Check out the BEM naming convention, it is very similar to what you are already doing.
http://getbem.com/introduction/
SUMMARY
Grade: Satisfactory
Summary: Nice job on this project, the site looks really good on desktop. Need a couple tweaks on mobile, but also pretty good. I really like your hover transitions and your code is well organized. Take a look at the issues I created as they will help you clean up the mobile display a bit as well as introduce some other techniques you can use. Overall really nice job, hope you enjoyed the course!
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.