Comments (5)
Look at issue #4. He elaborates on his benchmarks and provides some of the background information behind his benchmarks.
from fasthttp.
@Annonomus-Penguin I have seen that. But my doubt are something else, first is preffered usage SO_REUSEPORT
& prefork rather than normal multi-threaded. There's nothing about that in #4. Another is claim that fasthttp
works 4x-10x than net/http
. Again I cannot see the proof (example benchmark) for this claim.
Just to be clear, I am not denying that this solution is fast, it is VERY FAST. And it is 4th in my benchmarks, only loosing to some heavily optimized Java and 2 native C solution. So I think it is great.
from fasthttp.
@nanoant , first of all thanks for the benchmark.
According to your Performance optimization tips for multi-core systems using pre-fork with SO_REUSEPORT is preferred way to scale on multicore system.
However I get completely opposite numbers, when using prefork I get worse results (~440kreq/s) than with multi-threded simpler version (~480kreq).
Prefork with SO_REUSEPORT scales perfectly when a lot of concurrent client connections (at least thouthands) are established over the real network (preferrably 10Gbit with per-CPU hardware packet queues). See #4 for details. When small number of concurrent client connections are established over localhost, then SO_REUSEPORT usually doesn't give any performance gain (like in your case).
Also another important observation is that is performance increase comparing to net/http is around 1.8x, and it is nowhere close to claimed 4x-10x. Thoughts?
10x performance gain is achieved in synthetic benchmarks - see server benchmark results on the main page. These benchmarks completely skip network API provided by the operating system - they test bare server implementation performance. In real life fasthttp is faster than net/http by up to 3x (when client uses http pipelining) due to network API overhead.
As for the source code:
Replace
io.WriteString(ctx, "Hello World")
with
ctx.Write(helloWorldBytes)
where helloWorldBytes
must be initialized in global scope as:
var helloWorldBytes = []byte("Hello World")
This may improve benchmark performance, since it eliminates io.WriteString
overhead.
from fasthttp.
Just added io.WriteString
performance booster at 80105c1. @nanoant, make go get -u github.com/valyala/fasthttp
and re-run your tests.
from fasthttp.
Closing this issue, since this is not a bug.
from fasthttp.
Related Issues (20)
- Fix rapid reset of fasthttp is vulnerable HOT 2
- Is there a way to send early hints from fasthttp server? HOT 1
- Bug: Redirect location is always normalized
- why skip err check in request.URI HOT 4
- benchmark panics on client timing HOT 2
- why release v1.49.0 is marked as latest? HOT 2
- Question regarding streaming large bodies HOT 2
- how to use readLimitBody, i want to disable preParseMultipartForm HOT 4
- overflown -> overflowed
- Issue: Default Path Not Set in FastHTTP Client for URIs with Only Query Parameters HOT 1
- write: broken pipe HOT 1
- Possible race condition on fasthttp.RequestCtx
- custom dialer in fasthttp.Client does not respect request timeout HOT 3
- Question regarding TCPDialer and KeepAlive HOT 1
- FR: Callback when response is written HOT 7
- Fasthttp WSL 2.0 request timeout. HOT 3
- Code Leaks Memory on FreeBSD, but not on Linux HOT 4
- [Question]How to get the final real url after redirecting using DoRedirects?
- Path Traversal Attacks on Windows HOT 7
- HEAD request hangs HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fasthttp.