Comments (7)
Can you make a pull request including a test that fails before and passes after your change?
from fasthttp.
#1698 - created pull request.
How do you think about changing the function (normalizePath) more? Please check the changes
from fasthttp.
@egovorukhin @erikdubbelboer This was supposed to be reported using the process here: https://github.com/valyala/fasthttp/security
This could qualify for a CVE, and it was reported improperly.
from fasthttp.
I think we should just disable FS on windows. It's not safe, it's not properly tested and nobody should be using it in production.
from fasthttp.
Let's replace backslash with slash when used in windows, then a check for "path traversal" will occur. What do you think about this?
file - uri.go
func - normalizePath
if filepath.Separator == '\\' {
dst = replaceSlashes(dst)
}
https://github.com/egovorukhin/fasthttp/blob/4d48887eb813b0f1caac0217751888897f601d50/uri.go#L579
file - uri_windows.go
func replaceSlashes(dst []byte) []byte {
for i := range dst {
if dst[i] == '\\' {
dst[i] = '/'
}
}
return dst
}
from fasthttp.
I don't think that will fix it. How about we just reject all requests with ..
on windows?
from fasthttp.
Ok, let's do this. Do you have a solution?
from fasthttp.
Related Issues (20)
- Fasthttp panics HOT 4
- Accessing some context in a `RoundTripper` HOT 2
- Ignoring Requests with Long URI HOT 2
- question: Add user level value to connection? HOT 1
- FastHTTP doesn't validate HTTP versions HOT 2
- application/octet-stream header gets added by default in case of a DELETE request without body HOT 4
- question regarding header parsing HOT 1
- sse panic on fasthttphandler HOT 1
- [BUG?]: SSE Handler with Fiber web framework, any http client I have implemented cannot connect.
- Question: Add client.MaxResponseBody*Read*Size? HOT 2
- Bug: fasthttp client connect to Vite dev server on localhost, tcp4 127.0.0.1:5173: connect: connection refused HOT 2
- Support for Prometheus HOT 1
- CloseOnShutdown dont work? HOT 3
- how can i use fasthttp bare minimum "net" library only without routing through the http overhead? just pure tcp rpc stuff will do HOT 1
- What is a correct way to create a proper fasthttp.RequestCtx in the unit tests? HOT 1
- Timeout stream response connection does not clear buffer data for re-use HOT 2
- Propagate request error to RetryIfFunc HOT 1
- Expose `timeout` field in Request HOT 1
- NewFastHTTPHandler does not set response status code. HOT 1
- NewFastHTTPHandler does not set response status code HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fasthttp.