Comments (6)
Oh, I can totally submit a patch if I just get pointed in the right direction in terms of what filter_attributes()
was meant to do.
from validator.js.
It's a port of CodeIgniter's xss_clean()
helper. My preg
to RegExp
skills weren't great when I ported it ;)
It looks like the function removes Javascript comments embedded in attribute values before removing common attack vectors like javascript:
on this line.
from validator.js.
Thanks for the quick response! It still doesn't look quite right to me: the use of comments
seems to have be left over from a previous commit?
from validator.js.
Yeah rushed it a bit. I also split out the first regexp in to one for each quote so that the lazy .*?
doesn't choke on something like href="alert('foo');"
. I'll write test cases when I get some time
from validator.js.
Looks like this issue is back again, identical to when I reported it. Should I open a new issue or can we reopen this?
from validator.js.
Ok so I've changed the semantics a bit: if an offending attribute is found the whole thing is removed rather than just the evil pattern that was matched.
from validator.js.
Related Issues (20)
- Can't be used within remix routes HOT 7
- isLocale doesn't work anymore (returns true on wrong locals) HOT 4
- Add support uuid v7 for `isUUID` HOT 3
- isURL() returns false for long urls HOT 6
- The isDate function returns false for some timezones (e.g. North American time zones) HOT 2
- fix: Date is not validated as expected HOT 3
- Email validator accepts special character "ΒΈ" which should not be valid HOT 7
- Enhance assertion check for function "equals" HOT 2
- readme.md toBoolean function documentation typo HOT 4
- No Active Maintainers? New Maintainers Needed? How to Proceed? HOT 11
- `isISO8601` doesn't support duration HOT 3
- isEmail accepts &@<domain> HOT 3
- Inconsistent isSlug results with "." in the inputs HOT 2
- "Cannot find module" error for lib or es/lib modules HOT 4
- isDate returns false for all strings HOT 10
- extended ascii passed isEmail validation HOT 1
- isEmail does not reject emails when blacklisted_chars includes quote
- get list of supported countries for passports HOT 2
- Invalid URL get validated HOT 2
- "Cannot find module './util/assertString'" since 13.12.0 HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from validator.js.