Comments (4)
This is due to #2189
With that, can you figure out why it accepts those strings and what we need to change to fix it if that behaviour is incorrect?
from validator.js.
I'm not an expert on regexp.
But your 'language' rule seems way too permissive :
const language =
(([a-zA-Z]{2,3}(-${extlang})?)|([a-zA-Z]{5,8}));
I admire the fact you want to manage these locales with regexp, but I've got the feeling rules are too complex to handle it like that. Result is that isLocale returns true for many strings that are not locale at all...
Storing all locales (at least some part to build them) in an array could seem ugly and absurd at first, but well, it handles every specific rules and edge cases... that you don't manage with regexp.
from validator.js.
as mentioned by @WikiRik , it seems that the #2189 changes seem to have included language with generic language acceptance, as you mentioned, so if this need to be changed, will be happy to help regarding this. @sbatezat
from validator.js.
Obviously it needs to be changed.
To fix the fact isLocal() calls was not working with every good string (#2100) you made it working for almost every bad string...
from validator.js.
Related Issues (20)
- Add support uuid v7 for `isUUID` HOT 3
- isURL() returns false for long urls HOT 6
- The isDate function returns false for some timezones (e.g. North American time zones) HOT 2
- fix: Date is not validated as expected HOT 3
- Email validator accepts special character "ΒΈ" which should not be valid HOT 7
- Enhance assertion check for function "equals" HOT 2
- readme.md toBoolean function documentation typo HOT 4
- No Active Maintainers? New Maintainers Needed? How to Proceed? HOT 11
- `isISO8601` doesn't support duration HOT 3
- isEmail accepts &@<domain> HOT 3
- Inconsistent isSlug results with "." in the inputs HOT 2
- "Cannot find module" error for lib or es/lib modules HOT 4
- isDate returns false for all strings HOT 10
- extended ascii passed isEmail validation HOT 1
- isEmail does not reject emails when blacklisted_chars includes quote
- get list of supported countries for passports HOT 2
- Invalid URL get validated HOT 2
- "Cannot find module './util/assertString'" since 13.12.0 HOT 2
- π§: Stale Prs HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from validator.js.