Comments (3)
If API changes aren't made due to the fear to break code libraries won't get better.
The usual way would be to just have an alias for the old one and put a deprecation warning.
Imo the most annoying things are not the changes, it's that code breaks and you don't even know why. Deprecation warnings will make the transition smooth. Just like how Ryan did with the sys -> util module in Node.js.
Would you merge my pull request if I implemented the above suggestion with deprecation warnings? I would want to contribute to make this library better.
from validator.js.
I agree it reads better but I'm wary of changing an API that's a year old. Renaming functions at this stage would break a lot of code
from validator.js.
I'm still wary about doing this.
I completely agree with what you're saying with regards to changing API's and deprecating methods in the name of moving forward, but I think that introducing deprecated warnings for some minor naming inconsistencies is the wrong way to go considering that Javascript APIs are inherently open and that users can fix these inconsistencies with their own mixins.
Another thing is that this library is in use client-side as well as server-side so deprecated warnings are not only a pain for existing code, they don't really work client-side.
from validator.js.
Related Issues (20)
- isEmail() returning 'true' when entering wrong Domain name. like (.tom,bom etc). HOT 1
- French phone number validation showing invalid when with country code HOT 7
- What is the exact ISO 8601 format for isDate() ? HOT 4
- Can't be used within remix routes HOT 7
- isLocale doesn't work anymore (returns true on wrong locals) HOT 4
- Add support uuid v7 for `isUUID` HOT 3
- isURL() returns false for long urls HOT 6
- The isDate function returns false for some timezones (e.g. North American time zones) HOT 2
- fix: Date is not validated as expected HOT 3
- Email validator accepts special character "ΒΈ" which should not be valid HOT 7
- Enhance assertion check for function "equals" HOT 2
- readme.md toBoolean function documentation typo HOT 4
- No Active Maintainers? New Maintainers Needed? How to Proceed? HOT 10
- `isISO8601` doesn't support duration HOT 3
- isEmail accepts &@<domain> HOT 3
- Inconsistent isSlug results with "." in the inputs HOT 2
- "Cannot find module" error for lib or es/lib modules HOT 1
- isDate returns false for all strings HOT 8
- extended ascii passed isEmail validation HOT 1
- isEmail does not reject emails when blacklisted_chars includes quote
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from validator.js.