Coder Social home page Coder Social logo

Comments (3)

 avatar commented on June 22, 2024 1

If API changes aren't made due to the fear to break code libraries won't get better.

The usual way would be to just have an alias for the old one and put a deprecation warning.

Imo the most annoying things are not the changes, it's that code breaks and you don't even know why. Deprecation warnings will make the transition smooth. Just like how Ryan did with the sys -> util module in Node.js.

Would you merge my pull request if I implemented the above suggestion with deprecation warnings? I would want to contribute to make this library better.

from validator.js.

chriso avatar chriso commented on June 22, 2024

I agree it reads better but I'm wary of changing an API that's a year old. Renaming functions at this stage would break a lot of code

from validator.js.

chriso avatar chriso commented on June 22, 2024

I'm still wary about doing this.

I completely agree with what you're saying with regards to changing API's and deprecating methods in the name of moving forward, but I think that introducing deprecated warnings for some minor naming inconsistencies is the wrong way to go considering that Javascript APIs are inherently open and that users can fix these inconsistencies with their own mixins.

Another thing is that this library is in use client-side as well as server-side so deprecated warnings are not only a pain for existing code, they don't really work client-side.

from validator.js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.