Coder Social home page Coder Social logo

Comments (1)

valentinoli avatar valentinoli commented on June 14, 2024

It turned out that we were calling the api.js in CourseViz.vue where the data was not sure to have been loaded into local storage. So I changed the place where the data is loaded into local storage to the root component App.vues beforeCreated lifecycle hook, which makes more sense:

  async beforeCreate() {
    try {
      // Load all data to local storage
      // if it hasn't been loaded already
      await api.loadAllData();
    } catch (err) {
      console.error(err);
      this.error = err;
    } finally {
      this.loading = false;
    }
  }

As a consequence the displaying of the skeleton loader is now the root component's responsibility. And the skeleton loader is only displayed if the data is not present in the user's browser. Another upside about this is that the data is loaded regardless of which view the user opens first, and not only the index view.

from epfl-interactive-coursebook.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.