Comments (1)
It turned out that we were calling the api.js
in CourseViz.vue
where the data was not sure to have been loaded into local storage. So I changed the place where the data is loaded into local storage to the root component App.vue
s beforeCreated
lifecycle hook, which makes more sense:
async beforeCreate() {
try {
// Load all data to local storage
// if it hasn't been loaded already
await api.loadAllData();
} catch (err) {
console.error(err);
this.error = err;
} finally {
this.loading = false;
}
}
As a consequence the displaying of the skeleton loader is now the root component's responsibility. And the skeleton loader is only displayed if the data is not present in the user's browser. Another upside about this is that the data is loaded regardless of which view the user opens first, and not only the index view.
from epfl-interactive-coursebook.
Related Issues (20)
- Graph: Curved edges HOT 1
- Bug: Fixed arrow tips
- Graph: Add legend to explain meaning of node colors HOT 2
- Graph: Button to center the graph
- Graph: Group nodes by parameter
- Color: use appropriate color palettes HOT 1
- Course details: Scrape image of lecturers and add to card
- Bug: Graph tooltip overflows HOT 1
- Web: display an alert when a problem occurs when loading data into local storage
- Web: Site is slow initially when all data is displayed HOT 2
- Registrations Chart: The total number of students should be shown when we don't hover over the bar
- Web: Add SSL certificate and upgrade dyno
- UI: Fix horizontal margin/padding bug on mobile
- UI: Detect touch interface earlier HOT 3
- Graph: Resize SVG on window resize
- Graph: Remove scroll bar for large enough viewports and autoscroll legend
- Course tooltip disappears when hovering quickly between nodes
- Enable PWA
- Graph: Add links between courses based on recommendations
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from epfl-interactive-coursebook.