vaadin / bakery-app-starter-fw8-spring

Internal repository for Bakery App Starter for FW8 and Spring

Vaadin web components

This package contains all Vaadin web components (free and commercial).

See https://github.com/vaadin/web-components for more details.

bakery-app-starter-fw8-spring's Issues

Document "Getting started and customizing"

"How do you get the application up and running"
"How do you add a view"
"How do you add an entity"
“Tips for development workflow”
"How should you run things to get changes to show up as quickly as possible in your browser"

Document "Architecture overview"

"How does Designer help"
"How are test setup and run"
"How authorization works”
“What are the architectural boundaries and when to cross them

Scrolling board will switch over to scrolling grid if scroll causes the grid to be under the cursor

Steps to reproduce

1. Place cursor on top of board close to the bottom right corner, but not on the grid
2. Do a big scroll gesture to get to the bottom of the board

Expected result

View is scrolled all the way down

What happens

View scrolls down until cursor is on top of Grid, and then Grid starts to scroll instead of Board.

Test that a new order can be added

testNewOrderVisuals():

1. Storefront -> add
2. Assert view status, e.g. should not say "#null" like right now
3. Should not have a "set state" button
4. Should have enabled "Cancel", "Done", "Add items...", "Add comment" buttons

testAddOrder():

1. Storefront -> add
2. Fill data in all fields
3. Add a couple of items
4. Save
5. Assert order was saved

Add a delete button for products

A delete button will be added to each product row.
Setting quantity to 0 for a row should have the same effect.

Use column chart type for deliveries charts.

Fix password in user admin

Should not display the encrypted password, just allow changing password

Sometimes you need to click twice on a menu item to navigate

This is somewhat random - sometimes it works, most of the time it does not, especially on an iPhone

There should be a way to navigate back to the orders list from the edit view

The note at the bottom of the page should always be visible

The note could have position:fixed;bottom:0 and the main view content should have enough margin-bottom so that you can scroll all the way down.

Have an simple execution script in project root.

I keep forgetting that the run command in mvn spring-boot:run. I think we should have a script so that you can only type ./run in root to start up the project. It could directly call spring-boot. I think JHipster had something similar.

Test that the Storefront view is shown correctly

• Grid contains correct first and last row
• There is an "add" button

Test that an order can be updated

testAddComment()

1. Storefront -> select order
2. Add comment
3. Ensure comment is there and date + author is correct
4. Refresh
5. Ensure comment is there and date + author is correct

testUpdateCustomer():

1. Storefront -> select order
2. Modify all customer details
3. Save
4. Assert customer details were updated
5. Refresh
6. Assert customer details were updated

testUpdateProducts()

1. Storefront -> select order
2. Update type + quantity for existing
3. Add new product
4. Save
5. Assert product was updated
6. Refresh
7. Assert product was updated

testCancelUpdate()

1. Storefront -> select order
2. Update customer info
3. Update product info
4. Press cancel
5. Assert nothing changed
6. Refresh
7. Assert nothing changed

Reponsive menu does not close when selecting an item in the phone view

• The menu does not close when you select an item
• The menu does not close when you tap the menu icon

Optimize login page by using inline theme

There is no point in loading the full Valo theme to show the login page. Instead the login page should be stand alone and Valo should be loaded in the background while the user is logging in

Orders grid shows ellipsis for date

When the first column should say

Today
5/5/16

it says

Today
5/5/...

cause by vaadin/framework#8502

Document "Deployment and configuration for production"

"How do I use a real DB and disable data generation"
"How do I get it up and running on Wildfly/Tomcat/…"
"How do I deploy it to Beanstalk?" (covered by a separate issue)

Document "Setting up continous integration"

How do I setup the project on GitHub + Travis so that each PR is validated and tested automatically.

While the target audience likely does not use Travis, this will still cover the basic requirements for a CI setup. It can be later expanded to cover e.g. GitLab + Jenkins

Document how to deploy to AWS Elastic Beanstalk

Starting point: You have cloned the project
End result: The app is running in AWS Elastic Beanstalk

Implement proper CRUD logic for all admin views

The current one is missing a lot of the details

• set button caption according to state
• enabling/disabling buttons according to state (save/add/cancel/delete)
• navigating away when the form is open (show confirmation dialog)
• selecting another item when the form is open (show confirmation dialog)

Style orders grid status indicators

Product rows with product==null should be ignored

It should be possible to click "add item" N times, and still go to the next step w/o touching those.

• remove all "empty" rows when submitting

Login page: Pressing enter when cursor on 'username' or 'password' field should trigger the 'login' action / button

Scalability tests

There should be scalability tests and a report proving the scalability

Remove bulletin board

Decided not to include a bulletin board in the initial version

Implement sorting properly in the admin views

Document scalability test

• How can they be run locally
• How can they be run on a CI for validation that a patch does not destroy performance

Menu should show who is logged in

With a picture

Grid in Board does not work with ShadyDOM

Each row is 1px high. Possibly caused by webcomponents/shadydom#85

"Vaadin-Refresh" in login.html does not consider context path

Vaadin-Refresh: /login.htmlredirects to http://host.com/login.html, regardless of context path

Layout breaks when saving empty order

Name/phone breaks the layout when they get error styles. Updating the fields fixes the layout proiblems

Problem state with comment

The specs for the order edit page in report mode contains a "Problem..." button with a popup. The button should be added and the same popup should be shown if you select "Problem" in the "Set state" popup

Active menu item should be highlighted

Presenters must be serializable

Ensure no repository classes are used in UI classes

Verify that the generated database tables make sense

Orders grid does not fit on screen

The grid should be 100% wide and columns should fit into that. This is not possible to configure with FW8 Grid because of vaadin/framework#8548

Include license

Starting up server takes too long

Setting up server takes about 20s as it sets up a lot of repositories. Every time you make a code change and deploy it, you have to wait 20s for the redeployment. This is a productivity killer.

Verify that Hibernate can be changed to EclipseLink

Visual Design

Test that the Dashboard view is displayed correctly

• Stable data generation
• Assert values in boxes
• Assert grid has correct values in first row

Remove SubPropertyBinder once https://github.com/vaadin/framework/issues/8384 is fixed

Add margin to dashboard view

To crammed with no whitespace

TestBench test

There should be tests that prove all parts of the UI works

Instructions to everything.

Need documentation on how to get started with it. Also README could be longer.

Running application, Adding to IDE, running tests, what can be found where, etc...

Implement a paging data provider

Currently a lot of extra data is fetched because of a "naive" implementation.

After logging in you should end up on the desired view

If you go to http://localhost:8080/#!order/3335 when not being logged in, you should end up on http://localhost:8080/#!order/3335 after logging in. Right now you end up on the default view depending on the user

Improve order read-only-mode legibility

Just making the fields read-only makes for a very hard to scan page, with too much space etc.

Add a screenshot test to demonstrate how to use screenshot tests

1. Navigate to store front
2. Create new order
3. Compare screenshot