v8 / node

Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:

V8 JavaScript Engine

V8 is Google's open source JavaScript engine.

V8 implements ECMAScript as specified in ECMA-262.

V8 is written in C++ and is used in Google Chrome, the open source browser from Google.

V8 can run standalone, or can be embedded into any C++ application.

V8 Project page: https://v8.dev/docs

Getting the Code

Checkout depot tools, and run

    fetch v8

This will checkout V8 into the directory v8 and fetch all of its dependencies. To stay up to date, run

    git pull origin
    gclient sync

For fetching all branches, add the following into your remote configuration in .git/config:

    fetch = +refs/branch-heads/*:refs/remotes/branch-heads/*
    fetch = +refs/tags/*:refs/tags/*

Contributing

Please follow the instructions mentioned at v8.dev/docs/contribute.

node's Issues

Rebase to latest Node.js master, update to latest V8 ToT

/cc @fhinkel @matthewloring @hashseed @targos

The vee-eight-lkgr branch has a version of Node.js master from more than 2 months ago. I am going to use this issue to rebase to the latest master along with pickup the V8 ToT from this morning.

I am going to reset the head to what I have on my fork presently, specfically 1735fdf. Since rebase is destructive on the history, I have created a backup tag lkgr-backup-20170214 pointing the to present head: 9e76b83.

A few tests are still disabled in this branch. Most of these are related to debug.

Issues that need to be addressed as a follow-on:

• Debug::SetMessageHandler is a nop in V8 5.8. This means that node debug can no longer work. All the test using node debug should be migrated to use node inspect instead. I tried doing this, but was blocked by a bug that node --inspect-port=${port} doesn't seem to be getting propagated to the inferior. All instances of the node inspect inferior start on the same (default) port, causing grief. For now I have deleted the debug tests, but as a follow on these should be properly fixed.
• test-intl-no-icu-data.js is a new test. I didn't have time to look into why it is failing.
• I am not sure if the windows build issues have been addressed yet.

Create a branch on latest main

@victorgomes Can you create a branch based on latest main branch of Node? I'm starting to upstream changes to node-ci.

Security Policy violation Binary Artifacts

This issue was automatically created by Allstar.

Security Policy Violation
Project is out of compliance with Binary Artifacts policy: binaries present in source code

Rule Description
Binary Artifacts are an increased security risk in your repository. Binary artifacts cannot be reviewed, allowing the introduction of possibly obsolete or maliciously subverted executables. For more information see the Security Scorecards Documentation for Binary Artifacts.

Remediation Steps
To remediate, remove the generated executable artifacts from the repository.

Artifacts Found

• deps/zlib/google/test/data/evil_via_invalid_utf8.zip

Additional Information
This policy is drawn from Security Scorecards, which is a tool that scores a project's adherence to security best practices. You may wish to run a Scorecards scan directly on this repository for more details.

---

Allstar has been installed on all Google managed GitHub orgs. Policies are gradually being rolled out and enforced by the GOSST and OSPO teams. Learn more at http://go/allstar

This issue will auto resolve when the policy is in compliance.

Issue created by Allstar. See https://github.com/ossf/allstar/ for more information. For questions specific to the repository, please contact the owner or maintainer.

test: zlib-binding.deflate flaky

The async-hooks/test-zlib.zlib-binding.deflate.js test is flaky since we updated Node to Node master yesterday. Any async hooks folks want to look into this cc @addaleax @trevnorris? @Trott is seeing a corrupted double-linked list error with the same test (on Node master with his PR #17856).

  ---
  duration_ms: 0.264
  severity: fail
  stack: |-
    *** Error in `out/Release/node': malloc(): smallbin double linked list corrupted: 0x0000000002b8e990 ***

This is the builder: https://ci.chromium.org/p/v8/builders/luci.v8.try/v8_node_linux64_rel
Here's one of the builds with a malloc error: https://ci.chromium.org/p/v8/builds/b8957891491866158528