urbit / archeology-bridge Goto Github PK

This project forked from myetherwallet/etherwallet

bridge

License: MIT License

JavaScript 78.27% Smarty 1.09% HTML 14.55% CSS 5.62% PHP 0.44% Python 0.04%

archeology-bridge's Introduction

Urbit

Urbit is a personal server stack built from scratch. It has an identity layer (Azimuth), virtual machine (Vere), and operating system (Arvo).

A running Urbit "ship" is designed to operate with other ships peer-to-peer. Urbit is a general-purpose, peer-to-peer computer and network.

This repository contains the Arvo Kernel

For the Runtime, see Vere. For more on the identity layer, see Azimuth. To manage your Urbit identity, use Bridge.

Install

To install and run Urbit, please follow the instructions at urbit.org/getting-started. You'll be on the live network in a few minutes.

Contributing

Contributions of any form are more than welcome! Please take a look at our contributing guidelines for details on our git practices, coding styles, and how we manage issues.

You might also be interested in joining the urbit-dev mailing list.

Release

For details about our release process, see the maintainers guidelines

archeology-bridge's People

Contributors

Stargazers

Watchers

Forkers

vvisigoth bencalder jtobin kravets

archeology-bridge's Issues

Make a spawn view

Should be a matter of renaming the launch partial https://github.com/urbit/etherwallet/blob/mercury/app/partial/launch.html

Ship state error messages

An error message told me "ship is not in state 2". That should probable get rendered as "living".

Update state view to new lack of state

There is a decent amount of conditional formatting going on in the state view based on the ship state. Since this #18 has been changed, the conditional formatting needs to be changed as well.

https://github.com/urbit/etherwallet/blob/mercury/app/partial/state.html

Please refer to the latest commit of the constitution as the source of truth for which ship states can perform which transactions. https://github.com/urbit/constitution

Transaction doesn't clear on hitting "back"

If you generate a transaction and then click "Back" without submitting it, it isn't cleared and will show if you come back to the page later.

After clicking "create" to make a transaction, there is no indication of activity until the transaction has been built. For local nodes this is fine as all checks etc. happen nearly instantaneously. For external ones that may not always be the case, especially for users on slower connections. We should consider indicating activity. Even replacing the create button label with "creating..." and graying it out would be fine.

Same goes for sending transactions.

Vote link for locked ships

There's two vote links per ship right now, one for locked and one for living state. Since a locked ship can't vote, as the UI tells us if we try, that link shouldn't be there in the first place.

Update views for setTransferProxy

Will mostly be a matter of changing copy https://github.com/urbit/etherwallet/blob/mercury/app/partial/allowtransfer.html and, of course, the links in https://github.com/urbit/etherwallet/blob/mercury/app/partial/state.html

Allow transfer operations for living ships

After starting my galaxy, "Allow transfer" and "Transfer" are greyed out. These are valid operations, even for living ships. ("Unlocked" means either locked but past the locktime, or living.)

Needs to be more informative about security & best practices

MEW added a bunch of blurps to the different login methods telling users about why using a private key directly might be a bad idea, and why hardware wallets are good. See here. In general, their site contains a bunch of similar copy warning the user to stay safe and how to make sure they aren't being scammed.

I feel this is important to do when providing an accessible interface for potentially high-value operations. Especially if we're also going to serve it over our own web domain (which may or may not be a good idea, looking at how many MEW scam attempts there have already been using subtle URL changes as an attack vector).

It's less aesthetic, but I'd be very willing to give that up if it means educating users about proper security practices. Considering not all MUW users will be familiar with Ethereum, we sort of have an obligation to, don't we?

We need to work with checksummed Ethereum addresses

As per EIP-55 Ethereum addresses can be checksummed using capitalization as a form of incorrect-address protection. Input fields should accept these, and all addresses displayed should be rendered in their checksummed forms. Web3 has functions for doing this work.

Consolidate start and rekey functions into configureKeys

Please update these functions and all references throughout the urbitCtrl. (Adding a separate issue for view updates).

https://github.com/urbit/etherwallet/blob/mercury/app/scripts/controllers/urbitCtrl.js#L1315

Make sure that MUW is only capable of calling approve/setTransferProxy for sending ships (and safeTransferFrom to receive)

There are two ways to transfer a ship via the contract, one which doesn't require a double confirmation, and one that does. We want to enforce on the UI side that double confirmation is required.

Via @msutherl

Make sure escaping transactions can be sent

Attempting to escape my star to a locked or living galaxy gives this error message: "Not your ship. undefined"

cancelEscape added, escape semantics changed slightly

Recent changes added a cancelEscape(uint32) function to the constitution, allowing child ships to abort their escape themselves.

Useful when a child decides it doesn't like the parent it sent a request to after all, before it actually got adopted. Probably want to expose this alongside existing escape functionality.

Along with this change comes that we now have uint16 escape as a ship attribute, as opposed to uint32 escape. Since we can no longer set 65536 for the "no active escape" case, we instead have a bool escaping flag per ship. We want to update the checks the wallet does to match this.

Make sure vote transactions can actually be sent

I tried submitting an abstract vote. I can see it estimating the gas after I click "create", but nothing happens.

Clean up urbitCtrl.js

Remove all unused functions. Simple, right? ;)

Return users to a navigational page, not the action page they used

After clicking "dismiss" on a transaction confirmation, I still have to click "back" in the window with the form fields I filled out. Do we return to that intentionally? We may want to return to the layer above it (ie, the place where users can select another action to do and/or view new state) instead.

I tried to deposit a star and it didn't work

Hangs on creating. Not 100% sure that the first error message was related to this action or not, but the gas estimation error certainly was.

urbitwallet-master.js:50222 Possibly unhandled rejection: Attempting to run transaction which calls a contract function, but recipient address 0xb71c0b6cee1bcae56dfe95cd9d3e41ddd7eafc43 is not a contract address
urbitwallet-master.js:3165 directive triggered
urbitwallet-master.js:1433 Gas estimation error

Checksum public keys

This issue copied from an email thread.

@ohAitch,

Public keys should be checksummed. We very much do not want someone to enter i.e. "123456" as a public key and successfully set the galaxy to use it; though I guess they can just subsequently override that with the real fingerprint from the same UI ...

A simple XOR-to-zero style checksum is presumably calculable on the evm, and should still guard against typos.

Alternately we could just have urbit generate the pubkey in ethereum case-checksum format …

@Fang-

From the contract-side this obviously isn't practical to enforce.

From the UI side, I don't think any such checks are done. I remember banging in an arbitrary public key when testing this out myself and it working without complaining.

Yes, you can always change your public key as long as you have ownership of the ship, but I agree there's room in the UI for a sanity check like that.

Update all functions in urbitCtrl related to the state and lock time

There are various elements of the former constitution (and the javascript) that rely on checking the state of the ship. There are also checks related to lock time (the time after which a transaction can be performed on a ship).

An example is:
https://github.com/urbit/etherwallet/blob/mercury/app/scripts/controllers/urbitCtrl.js#L1071

In the new constitution, the states have been replaced by one status flag: active.

Remove all former references to the ship state and replace them with an appropriate status check.

I tried to escape a planet and it didn't work

Button depresses to Creating state and stays there.

urbitwallet-master.js:50208 Possibly unhandled rejection: Attempting to run transaction which calls a contract function, but recipient address 0xb71c0b6cee1bcae56dfe95cd9d3e41ddd7eafc43 is not a contract address
(anonymous) @ urbitwallet-master.js:50208
urbitwallet-master.js:3151 directive triggered
urbitwallet-master.js:1433 Gas estimation error
urbitwallet-master.js:3151 directive triggered

I tried switching to a new pool and it didn't work

I was using the wrong pool address. So I tried to change it, but pressing "Connect" does nothing.

Can't switch wallet login type after selecting one

Instead you have to either complete the login at which point the "Wallet" breadcrumb becomes clickable, or reload the page to start over.

Update variable names

There have been several updates to the variable names of the contract internals. In the interest of legibility, please update these accordingly.

pilot -> owner
children -> spawnCount
spawned
key ~> encryptionKey, authenticationKey
revision -> keyRevisionNumber
parent -> sponsor
escaping -> escapeRequested
escape -> escapeRequestedTo
launchers ~> launchProxy
transferrer -> transferProxy

Bring Votes interface in line with newest contracts

"Votes" contract has been replaced by "Polls." All interface functionality should be the same with the exception that a check needs to be added to make sure that an address has not voted already (previous versions allowed addresses to change vote).

Most changes here should be bringing function names up to date. Once again, the source of truth is: https://github.com/urbit/constitution/blob/master/contracts/Polls.sol

Don't let the galaxies escape!

We probably should be graying out "Escape" for galaxies, and disallow that in the constitution contracts as well...

Update views to reflect configureKeys

Since start and rekey are now one function, it'll be necessary to bring the views in line. This will consist in:

Consolidating the transaction views into one and https://github.com/urbit/etherwallet/blob/mercury/app/partial/start.html https://github.com/urbit/etherwallet/blob/mercury/app/partial/rekey.html
Changing references to these transactions on the state page https://github.com/urbit/etherwallet/blob/mercury/app/partial/state.html

Be more clever about reloading ship state

It seems to reload your ship listing every time you go back to the ship list page. Can this be cached? We'll probably just want to auto-refresh it on a one-minute timer after the user has performed a transaction, and stop doing that when we detect a change. Might be getting too fancy here though. At the very least, a manual refresh button sounds like it'd be good for user satisfaction.

Attempt to pull in changes from the original Ether Wallet

From following their Twitter, I know the guys over at MyEtherWallet haven't been sitting still. Bunch of updates seem to have gone out. Might be worth seeing if we can pull relevant parts back into this repo.

Make use of batch requests where possible

This is by no means a priority issue, but just want to have it documented.

The Ethereum node RPC API allows grouping of requests/calls/transactions into batches. We might want to use this in places where we need to perform multiple checks at once. Surely web3 and/or MEW code exposes this functionality somewhere. Might require refactoring of current request/check logic.

Support entry of ENS addresses into address fields

Moving this out of #47 and into its own issue, because this is on a separate (and lower priority) track of works.

We should support ENS names for address input fields, since people may have personal ENS addresses they want to use. Also useful for contract addresses, where those are variable.

Update configureKeys() and related read calls

As per this commit the Constitution's configureKeys() now takes a new parameter, used to signal the version number of the crypto suite the keys operate by. This should be 1 or higher.

Additionally, Ships' getKeys() has been updated to return not just the two current keys, but also their crypto suite and revision numbers. The read call done here may need to be updated accordingly.

Distinguish between locked and "unlocked"

No distinction between locked and unlocked ships. It'd be nice to at least have the locktime show for locked ships, and showing an orange "unlocked" when the locktime has passed shouldn't be too hard either.

Consolidate grantLaunchRights / revokeLaunchRights into setSpawnProxy

As found here:

https://github.com/urbit/etherwallet/blob/mercury/app/scripts/controllers/urbitCtrl.js#L1263

Update views to reflect setSpawnProxy

Follow up to #22

Update the relevant transaction detail pages (in https://github.com/urbit/etherwallet/tree/mercury/app/partial) and
Update the links from state.html