uportal-project / calendarportlet Goto Github PK

The colors shown next to the time of an event do not match the color assigned to the calendar they are from.

jQuery 1.12 is a target version for uPortal 5.

Steps to reproduce:

1. log in as student
2. in Calendar portlet, click Options --> Edit
3. click "Add a Calendar"
4. enter values for "Calendar name" and "Calendar URL" and click the "Save calendar" button
5. check CALENDAR_STORE table and notice how there are two new rows with the calendar name you entered
6. check CALENDAR_PREFERENCE table and notice how there are two new rows with the calendar URL you entered
7. in Calendar portlet edit screen, click "Edit Calendar" next to the new calendar you added (notice the "My Calendars" list does not have a duplicate entry)
8. change the value for "Calendar name" and "Calendar URL" and click the "Save calendar" button
9. check CALENDAR_STORE table and notice the last row was updated but the second to last row has the original value from step 4
10. check CALENDAR_PREFERENCE table and notice the last row was updated but the second to last row has the original value from step 4
11. check CALENDAR_CONFIGURATION table and notice there are no rows with CALENDAR_ID value that references the second to last rows in CALENDAR_STORE and CALENDAR_PREFERENCE (thus those rows are orphaned)

Changing permissions on the calendar is not being reflected.

1. As admin, add a new unauthenticated iCal feed (such as https://calendar.google.com/calendar/ical/en.australian%23holiday%40group.v.calendar.google.com/public/basic.ics ) and make available to Everyone.
2. Login as the staff user. Observe calendar and events appear.
3. Log back in as admin. Change the permissions on the recently added calendar to 'Portal Administrators'
4. Log back in as staff and observe that the calendar still shows up

Clearing the cache does not appear to help.

GitHub integrated builds failing due to missing packages. Might be related to the jasig repo having been retired recently.

The version of Hibernate in CalendarPortlet did not have Oracle10gDialect.

CVEs for the current versions of Spring Core and HttpClient. Appears that some tests fail with a quick update of the Spring version number. Also, there are some comments in pom.xml about NOT upgrading HttpClient for a particular service.

To replicate, got to Calendar portlet, click on title to maximize and reveal "Calendar administration" link.

1. Click on "Calendar administration"
2. Click on "+ Add a calendar"
3. Enter Calendar functional name and Calendar type
4. Click on "Next" button

Try adding a calendar on this page, and no calendar is saved.

There's a mismatch between the form method and the (portlet) URL type.

Calendar Portlet has no caching and this fact impacts performance for high user counts.

Caches should be created for https://github.com/Jasig/CalendarPortlet/blob/455ea40513ded472d51980644cbe2c5b3ca5f725/src/main/java/org/jasig/portlet/calendar/dao/HibernateCalendarStore.java

Christian noted:
More broadly we probably want to migrate to the new maven package for httpclient
v3: https://mvnrepository.com/artifact/commons-httpclient/commons-httpclient (currently used)
v4: https://mvnrepository.com/artifact/org.apache.httpcomponents/httpclient
v5: https://mvnrepository.com/artifact/org.apache.httpcomponents.client5/httpclient5

In both our development version (v5.1.2) and the most recent "vanilla" version of uPortal and uPortal-start (v5.2.3), I can't add or edit calendars in the Calendar portlet (v2.6.0).

Steps to reproduce after deploying locally with uPortal-start:

1. log in as staff or student
2. click on Calendar portlet name to maximize portlet and reveal Preferences link
3. click on Preferences
4. click on + Add a calendar
5. fill in Calendar name and Calendar URL
6. click on "Save calendar" button

No new calendar.

Does this happen for you? Could you see if others report the same behavior? It's easy to check if you have uPortal 5 running.

After much debugging I think I know what the problem is but I don't know how to resolve it.

On the "Edit calendar" page (editCalendarUrl.jsp), after entering a Calendar name and Calendar URL, when I click the "Save calendar" button, it's supposed to redirect to Action "editUrl" but it's not getting there because the request looks like this:

http://localhost:8080/uPortal/f/welcome/p/calendar.u25l1n13/max/action.uP?_csrf=403fcb62-9a79-4a32-8874-3a09a1af64f0&pP_action=editUrl

The _csrf parameter is encoding the ampersand as "&" instead of an "&" before the next parameter, "pP_action=editUrl" so in the browser (Chrome), the Query String Parameters list ends up looking like:

_csrf: 403fcb62-9a79-4a32-8874-3a09a1af64f0
amp;pP_action: editUrll

It looks like the "&" isn't getting decoded back to "&" so the second query parameter ends up being "&pP_action" which is likely not being recognized by Spring Portlet or uPortal or whatever processes "pP_action" as an action request.

I've put debug statements in EditUserHttpICalController on the showHttpCalendarForm and updateHttpCalendar methods and it never gets to the updateHttpCalendar method, suggesting that uPortal or the CalendarPortlet isn't decoding the "&" properly. I noticed that this is using Spring Web MVC 3.1.3.RELEASE which is pretty old.

I tried it with uPortal 5.2.3 and CalendarPortlet 2.6.0 using uPortal-start (./gradlew portalInit, ./gradlew tomcatDeploy, ./gradlew tomcatStart) as both admin and staff. Click on Calendar name in portlet header to expand to full screen and display Preferences (and Administration for admin user).

Latest fixes have highlighted an issue with session caching in Admin UI.

Example 1:

1. As admin, add a new shared calendar feed.
2. Observe on the admin calendar list that the new feed appears.
3. Return to 'View Calendars'
4. Observe that the new feed is missing in view preferences.
5. Log out and back in as admin
6. Observe the new feed is present in view preferences.

Example 2:

1. Delete a shared calendar feed in the Admin calendar page.
2. Observe that the deleted calendar is still listed.
3. Attempt to delete the calendar and observe that a error is thrown.

Flushing the EhCache does not correct this caching issue. This led me to believe it is in the Hibernate Session (as opposed to Http session). Transactions may not be set up correctly. Some experimentation with flushing and clearing the template in HibernateCalendarStore did not seem to help. Might be that the action request that does the updates but the call to get the calendar feeds is in the redirect. Also worth noting is that adding a new feed seems to manifest differently than deleting a feed!

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Repository problems

These problems occurred while renovating this repository. View logs.

• WARN: Package lookup failures

Rate-Limited

These updates are currently rate-limited. Click on a checkbox below to force their creation now.

• chore(deps): update dependency com.sun.xml.bind:jaxb-impl to v2.3.9
• chore(deps): update dependency javax.portlet:portlet-api to v2.0-draft32
• fix(deps): update dependency com.sun.xml.ws:jaxws-rt to v2.3.7
• fix(deps): update dependency joda-time:joda-time to v2.12.7
• fix(deps): update dependency xalan:serializer to v2.7.3
• fix(deps): update slf4j monorepo to v2.0.13 (org.slf4j:jcl-over-slf4j, org.slf4j:log4j-over-slf4j, org.slf4j:jul-to-slf4j, org.slf4j:slf4j-api)
• chore(deps): update dependency org.apache.maven.plugins:maven-checkstyle-plugin to v3.4.0
• chore(deps): update dependency org.apache.maven.plugins:maven-javadoc-plugin to v3.7.0
• chore(deps): update dependency org.apache.maven.plugins:maven-release-plugin to v3.1.1
• chore(deps): update dependency org.apache.maven.scm:maven-scm-api to v2.1.0
• chore(deps): update dependency org.apache.maven.scm:maven-scm-provider-gitexe to v2.1.0
• chore(deps): update dependency org.jvnet.jaxb2.maven2:maven-jaxb2-plugin to v0.15.3
• chore(deps): update dependency org.lesscss:lesscss-maven-plugin to v1.7.0.1.1
• chore(deps): update jaxb2basicsversion to v0.13.1 (org.jvnet.jaxb2_commons:jaxb2-basics, org.jvnet.jaxb2_commons:jaxb2-basics-runtime)
• chore(deps): update resource-server.version to v1.5.0 (org.jasig.resourceserver:resource-server-plugin, org.jasig.resourceserver:resource-server-utils, org.jasig.resourceserver:resource-server-content)
• fix(deps): update dependency com.fasterxml.jackson.core:jackson-core to v2.17.2
• fix(deps): update dependency com.fasterxml.jackson.core:jackson-databind to v2.17.2
• fix(deps): update dependency commons-codec:commons-codec to v1.17.1
• fix(deps): update dependency commons-io:commons-io to v2.16.1
• fix(deps): update dependency org.hsqldb:hsqldb to v2.7.3
• fix(deps): update dependency org.jasig.portal:uportal-spring to v5.16.1
• chore(deps): update actions/checkout action to v4
• chore(deps): update actions/setup-java action to v4
• chore(deps): update dependency com.sun.xml.bind:jaxb-impl to v4
• chore(deps): update dependency javax.portlet:portlet-api to v3
• chore(deps): update dependency org.apache.maven.plugins:maven-surefire-plugin to v3
• chore(deps): update jaxb2basicsversion to v1 (major) (org.jvnet.jaxb2_commons:jaxb2-basics, org.jvnet.jaxb2_commons:jaxb2-basics-runtime)
• fix(deps): update dependency com.ibm.icu:icu4j to v75
• fix(deps): update dependency com.sun.xml.ws:jaxws-rt to v4
• fix(deps): update dependency jakarta.xml.ws:jakarta.xml.ws-api to v4
• fix(deps): update dependency org.apache.portals.pluto:pluto-taglib to v3
• fix(deps): update dependency org.hibernate:hibernate-tools to v5
• fix(deps): update dependency org.jasig.portlet.courses:courses-portlet-dao to v2
• fix(deps): update dependency org.mnode.ical4j:ical4j to v4
• fix(deps): update spring core to v6 (major) (org.springframework:spring-test, org.springframework:spring-orm, org.springframework:spring-jdbc, org.springframework:spring-aop, org.springframework:spring-context-support, org.springframework:spring-core)
• fix(deps): update spring ws to v4 (major) (org.springframework.ws:spring-ws-security, org.springframework.ws:spring-ws-core)
• 🔐 Create all rate-limited PRs at once 🔐

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• fix(deps): update dependency ch.qos.logback:logback-classic to v1.3.12 [security]
• fix(deps): update dependency org.hibernate:hibernate-core to v5 [security]
• fix(deps): update dependency org.springframework:spring-beans to v5 [security]
• fix(deps): update dependency org.springframework:spring-context to v5 [security]
• fix(deps): update dependency org.springframework:spring-web to v6 [security]
• fix(deps): update dependency org.hibernate:hibernate-tools to v3.6.2.final
• fix(deps): update dependency org.jasig.cas.client:cas-client-core to v3.6.4
• fix(deps): update dependency org.jasig.portlet.courses:courses-portlet-dao to v1.0.1
• fix(deps): update spring ws to v2.4.7.release (org.springframework.ws:spring-ws-security, org.springframework.ws:spring-ws-core)
• chore(deps): update dependency javax.servlet:javax.servlet-api to v3.1.0
• fix(deps): update dependency org.jasig.portlet.utils:portlet-form-resources to v1.1.3
• chore(deps): update dependency javax.servlet:javax.servlet-api to v4
• fix(deps): update dependency org.mockito:mockito-core to v5
• Click on this checkbox to rebase all open PRs at once

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

if you have a dead link if the other server never responds it does not time out, it will just endlessly retry the link. also many of the calendars out there are using ical format with the webcal:// protocal. and the calendar portlet does not recognize them.