uploadcare / uploadcare-redactor Goto Github PK

Hey there

Looking at the latest example at https://imperavi.com/redactor, it seems like images should be wrapped inside a <figure> tag (or whatever imageTag is set to) after insert, to be consistent with the default redactor behavior.

See: https://imperavi.com/redactor/docs/settings/images/#setting-imageTag

This specifically plays a role when a caption is present, as redactor otherwise doesn't recognize it as a caption for that image.

Repro would be:

1. Insert image via uploadcare
2. Click the image to open the modal and add a Caption, Save.
3. Click the image again, the caption field is empty.

console errors on example.html

• Download the repo to a webserver
• hit example.html
• Notice errors

[Error] Failed to load resource: the server responded with a status of 404 (Not Found) (redactor.css, line 0)
[Error] Failed to load resource: the server responded with a status of 404 (Not Found) (redactor.js, line 0)
[Error] TypeError: undefined is not a function (evaluating '$('#redactor').redactor')
    (anonymous function) (index.html, line 11)
    j (jquery.min.js, line 2)
    fireWith (jquery.min.js, line 2)
    ready (jquery.min.js, line 2)
    I (jquery.min.js, line 2)

We created an extension of this library and added support for Redactor X. Should we create a PR so this library would support v2, v3 and Redactor X or would it make sense to create separate repository for Redactor X?

I have uploaded one image and it is in the redactor widget now.(I am using Click-To-Edit mode)
But the modal is not showing when the image is clicked inside the redactor widget and it works only when the out side of the image is clicked on the redactor editor.
Anybody knows why?

Would it be possible to implement drag and drop directly to the Redactor editor which background upload to uploadcare?

I'd like to use uploadcare for all our images and when somebody pasted and image or drops it into redactor, this should all land on uploadcare.

Thanks for your inputs. Also happy to help if it fits the scope of this plugin.

added in #3