unruly / vast-parser Goto Github PK

This isn't an issue, just a newbie user error. I'm having a difficult time setting up a basic test page. I created an index.html file and used the vast-parser.amd.js script but i'm unable to call the vastAdManager.requestVastChain to load the vast .xml that I would like to parse. Is there a little more detail you can give about setup or maybe provide a working html file?

Due to the core use case of vast-parser being to transform data from one structure to another, a type system will provide a huge benefit.

The main benefit is that the structure of VastResponse can be self-documented and enforced. Right now, that structure isn't entirely obvious.

The other benefit is to auto-generate documentation (by using something like typedoc). Keeping the README up-to-date and accurate by hand isn't easy.

With a type system, it'll also make it easier to move towards a more functional approach. Eventually allowing an application to tree-shake any unused code.

jQuery is currently used for:

• Event Emission
• Requesting VAST via AJAX

This seems overkill considering how large jQuery is.

Event Emission

Event Emission can be reimplemented easily, or a smaller library can be used.

AJAX

We can switch over to the Fetch API for requesting VAST. We have multiple options:

1. Use the Fetch API directly and assume it's on global scope. If an application supports an environment that doesn't have the Fetch API, they're expect to polyfill it on their end (ideally via dynamic imports or targeted bundles).
2. Use a polyfill like isomorphic-fetch. This will increase the size of library and not all environment will need the polyfill.

I'd go with Option 1 as the Fetch API seems widely supported in most browsers. And IMO, supplying polyfills for certain environments is not the job of a library.

On Install packages need to be upgraded.

I am a current Unruly employee, is anyone still working on this are have ownership (can be contacted)?

https://dependabot.com/

We probably want to remove jQuery first to avoid having to deal with any issues related to it. See #7.

From #4 - provide an example page that uses the parser and does something with a sample VAST file.

I can help if needed.