Coder Social home page Coder Social logo

junit-rules's People

Contributors

mrwilson avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

junit-rules's Issues

@IgnoreUntil class annotation is required and overrides method annotation

@IgnoreUntil("2099-01-01") has to be declared on the class for this rule to work at all.
It would be better if it was optional and just having a method annotation also worked.

public class IgnoreUntilTest {

    @Rule public IgnoreUntilRule rule = new IgnoreUntilRule();

    @IgnoreUntil("2099-01-01")
    @Test
    public void wantToIgnore() {
        Assert.fail();
    }
}

When @IgnoreUntil("2099-01-01") is declared on the class, it's value will be used on all methods that are also annotated with @IgnoreUntil.
This is fine if you want to share a date across a subset of the tests.
Not great if you also want to specify a date at the test level.

A better solution would allow shouldNowExecute() to be ignored based on the @IgnoreUntil("2018-01-01") annotation rather than the class annotation.

@IgnoreUntil("2099-01-01")
public class IgnoreUntilTest {

    @Rule public IgnoreUntilRule rule = new IgnoreUntilRule();

    @IgnoreUntil
    @Test
    public void wantToIgnore() {
        Assert.fail();
    }

    @IgnoreUntil
    @Test
    public void wantToIgnore2() {
        Assert.fail();
    }

    @IgnoreUntil("2018-01-01")
    @Test(expected = AssertionError.class)
    public void shouldNowExecute() {
        // this incorrectly 'passes' due to being ignored rather than AssertionError
        Assert.fail();
    }

    @Test(expected = AssertionError.class)
    public void dontIgnore() {
        Assert.fail();
    }
}

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.