Comments (4)
What's the impact of setting material last (other than working around the issue)?
from uno.gallery.
What's the impact of setting material last (other than working around the issue)?
from uno.gallery.
dont we always initialize XamlControlRsources first?
the obviously impact is the default control styles, since the last initialized library will contribute first
also didnt we went over this last time, and there are problem no matter which gets initialized last? either fluent style or material style is broken depending on the order.
from uno.gallery.
Two paths:
- Material -> Fluent and then we re-init Material in the MaterialContentPresenter for the SamplePageLayout here This is our current method
- Fluent -> Material and then we re-init Fluent in the FluentContentPresenter for SamplePageLayout here
With Option 1 we are re-initializing the lesser of two evils since I would assume MaterialToolkitTheme is less heavy than XamlControlsResources (right?). Downside is we aren't using Material by default for the styling of the outer shell of the application, so we may run into issues similar to what we originally had if we were to start using CheckBoxes/RadioButtons/etc. outside of just the sample areas.
With Option 2 we are re-initializing XamlControlsResources, which is probably pretty large. Although, it would probably be re-initialized less often as Material is usually the default tab to be loaded when opening up sample pages (actually not sure if the resource would be loaded regardless or only if the contentpresenter's visibility changes to visible?). Upside is that Material is the default styling for the entire application in this case
After doing a quick test, the problem we are seeing here is avoided if we initialize Material last (Option 2)
I'm good with swapping the order but this still doesn't address why this isn't working specifically on mobile when you have a TemplateBound property that is set to an overridden ThemeResource
from uno.gallery.
Related Issues (20)
- InformationalVersion value is incorrect in published app
- [Gallery][All Platforms]Cupertino palette-When changing the theme, text is not visible for all 'CupertinoSystemFillBrush' options.
- [Gallery][Wasm] There is a wired double linking happening in Uno gallery [Dark Mode] HOT 2
- [Gallery][Skia.Gtk] InfoBadge - 'Numeric Value', 'Style', 'Opacity' sections are missing. HOT 1
- [Gallery][Skia.Gtk] MenuBar- The text for the opened MenuFlyoutItem is truncating and not properly visible.
- [Gallery][Skia.Gtk] TextBlock - The text for the words “Bold and Italic” is not displaying in bold and italic form as expected. HOT 2
- [Gallery][Skia.Gtk] Lottie - A blank space is present when scrolling down the screen.
- [Gallery][All Platform]Lightweight Styling(Material)-The 'Overridden Radio Button style - Unchecked' button is being displayed as checked. HOT 1
- [Gallery][WASM]Typography-When the screen is resized, the text for 'Size/Line Height' is truncating, and the text related to the first row, such as 'Examples, Weight', is hiding.
- [Wasm] DataGrid doesn't load HOT 6
- `ContentDialog` doesn't have the proper theme
- Flyout samples are all Material HOT 4
- [iOS] Search doesn't show the name of the searched control
- Selecting an item scrolls the navigation view up HOT 7
- [Gallery][Windows][ShadowContainer] Crash on selection of Tabbar Neumorphic Style dropdown toolkit sample page. HOT 6
- Enable UI tests that got disabled in #1115
- Add copy button to resources in Typography sample page HOT 1
- [Toolkit/TabBar] Improve `TabBar` sample
- [Gallery][iOS] AutoSuggestBox- The indentation for all the displayed control names with definitions is incorrect. HOT 2
- [Gallery][Wasm][WCT - DataGrid] Unable to scroll down or up HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from uno.gallery.