unleash / unleash Goto Github PK

The developers are considering using Postgresql or Cassandra for the persistence layer because those databases are in the technology stack of Finn.no.

@jarib is looking into how we can use LevelUP

Decide initial schema for our api.

suggestion:

{
  "name" : "featureName",
  "status" : "on/off/custom",
  "customKey" : "user",
  "customValue" : "beta,employee",
  "activeFrom" : "2012-04-23T18:25:43.511Z",
  "activeTo" : "2012-04-23T18:25:43.511Z"
}

http://choosealicense.com/

The developers have agreed on the Apache License 2.0.

We sometimes have builds failing because of jshint errors. We might improve that by having Git run npm test before the push is allowed.

Should we introduce links in our api?
Example:

{
  "name": "myFeature",
  "description": "myDescription",
  "enabled": false,
  "strategy": "default",
  "parameters": null,
  "_links": {
    "events": {
      "href": "http://foo/events/myFeature/events"
    },
    "strategy":{
      "href":"http://foo/strategies/default"
    }
  }
}

Using hal might decouple the admin interface and the server a little bit.

http://stateless.co/hal_specification.html

The developers decided to host the repository on Github under the finn-no organization.

It should be possible to get a new client implementation "verified" through a common test suite.

Express etc.

We need to support some user authentication.
Passport (http://passportjs.org/) looks nice and we might have to make a SPID passport provider if we want to use SPID for authentication.

Figure out why travis fails on this:
npm ERR! Error: Attempt to unlock db-migrate@^0.7.1, which hasn't been locked
https://travis-ci.org/finn-no/unleash/builds/38905361

We need to setup some integration tests.

We must decide on what java-version to use in the client.

jdk8

• json api: http://www.oracle.com/technetwork/articles/java/json-1973242.html.
• no third party json parsing required
• requires all users of client to use java 8

jdk7

• requires us to have a json-parser library included (gson, jackson or similar)
• allows clients to use jdk7

Hvis man redigerer flere features samtidig blir det krøll med id-attributt på form-elementene.

Burde være greit å fikse med å prefikse id-ene med feature.name.

Currently you can only change one field per request, but after introducing an edit mode in the feature UI, several changes may happen at once.

It should be possible to change "enabled" state.

In admin you should be able to add a new strategy.

Finn just opend Spaden aka Styleguide so we can now use that if we want. 😄

Alternatives:

• FINNs internal framework
• Twitter Bootstrap
• Pure

As mentioned in #45

http://knexjs.org/

We need to setup a fork for the Finn specific Java client in stash.

Implement support for active_to [and/or] active_from strategy.
We should evaluate this on the server, so the client can handle this in the same way as the on/off strategy.

Support custom strategies. Should it be possible to share custom strategies between different features or should it be feature specific?

We should set up webpack or browserify to build our front-end resources

Skjema++

We want unleash-server to log all changes of feature states in a audit trail.

There's currently no way of tracking what toggles are being used across applications. The simplest I can think of is to add easy statsd/graphite reporting in the client.

Perhaps look at Yammer Metrics. From reading the Kafka docs it sounds pretty nice:

Kafka uses Yammer Metrics for metrics reporting in both the server and the client. This can be configured to report stats using pluggable stats reporters to hook up to your monitoring system.

The client should not stop the application from starting or working if unleash-server is unavailable or acting up.

Enforce defaults for every feature toggle used by the application.

We should add code coverage. Maybe we should add a service like https://coveralls.io/.
Istanbul (https://github.com/gotwarlost/istanbul) works nicely with Mocha.

Show the event log for each feature.

We should add source maps to make it easier to get fast feedback (http://www.html5rocks.com/en/tutorials/developertools/sourcemaps/)

It is impossible in the GUI right now to change the activation strategy for a feature toggle if the chosen strategy is deleted.

It should be possible to filter the toggles in the admin.
We could add tags like Pipeline did it but in the first version it is probably best to just add a search.

http://facebook.github.io/react/blog/2014/10/28/react-v0.12.html
There are a few things we can change.

The developers are considering using Node.js as the programming language of unleash-server.

Been reading about facebook's js-testframework Jest . Looks promising.

Pros:

• provides automocks for CommonJS modules
• integrates easily with React.
• built on top of Jasmine
• faster than karma (no browser)
• integrates better with node

Cons:

• Not executed in the browser, uses jsdom instead (e.g. like Karma does. This can also be a pros imho).

We need a feature to remove feature toggles from the gui as we want users of the service to get rid of the toggles as soon as possible.

It is important that this is implemented as an archive of some sort (or just a deleted flag). It will be really bad if "user 1" deletes "toggle A" and "user 2" accidentally revokes the toggle by creating a new feature toggle with the same name.

In admin you should be able to navigate through existing feature toggles.

Implement on/off strategy for unleash-server

More information about CLA
We can maybe use something like Clahub.

Example from:
Discourse
Node.js
Google

Have we landed on what app/feature to test Unleash on?

In admin you should be able to add new feature toggles.

We should strive to not use third party libs and just use native java code for this.

We have a milestone called "mfinn production test" here https://github.com/finn-no/unleash/milestones/mfinn%20production%20test

The deadline was 28.11.
Is this something we have done or are going to do?
Should we just close this issue and this milestone?