uniswap / router-sdk

@uniswap/router-sdk - Now at Uniswap/sdks

All versions after 1.9.0 of this SDK can be found in the SDK monorepo! Please file all future issues, PR’s, and discussions there.

Old Issues and PR’s

If you have an issue or open PR that is still active on this SDK in this repository, please recreate it in the new repository. Some existing issues and PR’s may be automatically migrated by the Uniswap Labs team.

router-sdk's Issues

add v2+v3 trade support to SwapRouter

Swap+Add: Support permit for output token (which, in some cases, must be pulled for adding liquidity)

Currently it's only supported to use permit for input tokens since that's all that's needed for a simple swap.
I think this is low priority right now, but should be added later (unless someone thinks otherwise).

Support mixed paths in routing-sdk

Branch on `0x` rather than string in deadlineOrBlockHash validation

This line should check startsWith(0x) instead of string

https://github.com/Uniswap/router-sdk/blob/master/src/multicallExtended.ts#L38

Create a Trade object to wrap v2/v3 trades

Add Swap and Add Calldata Formatter

Incorrect Calculation for Trade.minimumAmountOut

The math for the Trade.minimumAmountOut() is wrong. This is an issue in the interface because the Minimum output in the SwapDetailsDropdown is showing the wrong number.

Steps to Reproduce

1. Go to app.uniswap.org
2. Add two tokens to swap (Easier to test with two stablecoins like USDC & DAI)
3. Add Custom Slippage (Easier to test with a round number like 50%)
4. Open SwapDetailsDropdown see the incorrect number in the "Minimum output" row

Expected Behavior

Trade.minimumAmountOut() method should correctly calculate the slippage

Additional Context

In the screenshot the Minimum output is 666.604 when it should be 499.953.

add v3 trade support to SwapRouter

create route->`Trade` transformer inside router-sdk

see https://github.com/Uniswap/interface/blob/main/src/state/routing/utils.ts#L10 and other surfaces