unistra / django-cas Goto Github PK

File : django_cas/views.py in _service_url L.51
Problem : can only concatenate list (not "generator") to list

Fixed by :

• L.43 query_list = query_dict.items()
  +L.43 query_list = list(query_dict.items())

Problem

Previously, the CAS_ADMIN_PREFIXshould be used to enable / disable the cas authentication for the admin application. It is not working and cas authentication can't be disabled.
This setting must be a string representing the base path to the admin interface configured in url patterns.

Suggestion

CAS_ADMIN_PREFIX should be deprecated in favor of a new parameter called CAS_ADMIN_AUTH. This new parameter must be a boolean and is true by default. That won't break previous configuration in Django projects. When the parameter is false, the default login page should be displayed to allow users to authenticate to the admin application. However, users must be able to access directly to the cas authentication within this page. A link should be therefore displayed.

File : django_cas/views.py in _logout_url L.104
change :
url += '?' + urlencode({'url': protocol + host + next_page})
By :
url += '?' + urlencode({'service': protocol + host + next_page})
Seems to fix this problem
Is-it possible to add some REDIRECT_FIELD_NAME_AFTER_CAS_LOGOUT or something like that to permit redirect after logout in CAS ?
Thanks and regards

Hi,

I try to use this module with Django 2.x and it's not working.

Any plan to support Django 2.x ?

Error exemple :
    if request.user.is_authenticated() => request.user.is_authenticated:

MiStErLu