unclecheese / mappable Goto Github PK

If no points are drawn on the map then the centre point is not calculated (it is empty). This means that invalid javascript is generated. I guess a sensible default would be 0,0

Use phpcs to tweak code, alter scrutinizer config to start complaining about code compliance issues

hi

With regards to a request from a client, I now have a working copy of Mappable with the google maps API V3 both for the map itself and markers, along with clustering. Do you have a standard test map Uncle Cheese I can use for the other functionality, e.g. lines?

I'll provide a patch once I've retrofitted it into the mainstream Mappable, as I made a number of small changes (e.g. changed the getLatitude in the interface to getMappableLatitude due to a clash with a variable called Latitude in the model)

Regards

Gordon

Line 471 of GoogleMapAPI.php looks problematic

            if(($obj->getLatitude() > 0) || ($obj->getLongitude() > 0)) {

I assume this is meant to be checking for null points. However if both points are negative, then this will also fail the check. As such I think it should be != 0 instead of >0 for the coordinate checks above

Regards

Gordon

If no points are drawn on the map then the centre point is not calculated (it is empty). This means that invalid javascript is generated. I guess a sensible default would be 0,0

Hi Uncle Cheese,

i noticed that markers can be set with a custom category and you also write about the function getMapCategory() in your blog post - but it's not part of the Mappable interface.

Bug or feature?

cheers,

wmk