uki00a / carol Goto Github PK

• https://github.com/uki00a/carol/runs/704032173
• https://github.com/uki00a/carol/runs/703998960

test Application#onExit ... FAILED (96ms)
    at Object.receive (file:///home/runner/work/carol/carol/transport.ts:44:13)
    at async ChromeImpl.readLoop (file:///home/runner/work/carol/carol/chrome.ts:241:13)
error: Uncaught ConnectionReset: Connection reset by peer (os error 104) 
    at unwrapResponse ($deno$/ops/dispatch_minimal.ts:63:11)
test custom executablePath ... Makefile:7: recipe for target 'test' failed
    at Object.sendAsyncMinimal ($deno$/ops/dispatch_minimal.ts:106:10)
    at async Object.write ($deno$/ops/io.ts:65:18)
    at async BufWriter.flush (https://deno.land/[email protected]/io/bufio.ts:479:25)
    at async writeFrame (https://deno.land/[email protected]/ws/mod.ts:144:3)
make: *** [test] Error 1
##[error]Process completed with exit code 2.

🤔 😢

Currently, this module is tested only on Linux and Windows. I think that this module should be tested on MacOS as well.

How it can be build to .exe or something runable for windows?

Hello, when trying to run the example application, it fails with following error: Browser target is not found.
Error stack:

C:\__work\carol-test>deno run -A  hello.ts
Check file:///C:/__work/carol-test/hello.ts
error: Uncaught (in promise) Error: Browser target is not found
            throw new Error('Browser target is not found');
                  ^
    at Browser.target (https://unpkg.com/[email protected]/lib/esm/puppeteer/common/Browser.js:302:19)
    at Application.init_ (https://deno.land/x/[email protected]/carol.ts:118:18)
    at launch (https://deno.land/x/[email protected]/carol.ts:806:15)
    at async file:///C:/__work/carol-test/hello.ts:4:13

Chrome version: 107.0.5304.63 (Official Build) (64-bit)
OS: Windows 10 Pro 22H2

• Rewrite code base using puppeteer (#55)
• Fix carol to work on Windows (#51)
• Improve documentation (#19)

Hello, is it possible to disable resizing of the window?

Thanks

• Detect and fix bugs (seems to be fixed at #55)
• Run CI on Windows as well (#54)

See #49

https://doc.deno.land/https/deno.land/x/carol/mod.ts

• Add more jsdoc comments
• Improve README.md

This what happens when I try increasing the starting size of the window.

Following the example from the app, this is the only thing I changed:

const app = await launch({
  title: "Hello Deno!",
  width: 1280,
  height: 720,
});

Using Linux, POP!_OS, a Ubuntu derivative. Newest Chrome is installed on my system.

Deno.addSignalListener and DenoremoveSignalListener have been stabilized in Deno v1.19

We should handle signals with those APIs

Idea

import { enterTestMode } from "./mod.ts"; // See `deno doc carol.ts enterTestMode`

test("examples/hello", async () => {
  enterTestMode();
  const prevResources = Deno.resources();
  await import("./examples/hello.ts");
  const currResources = Deno.resources();
  cleanup(diff(currResources, prevResources)); // Surely this isn't ideal...
});

If I execute the carol sample code with url specified, an error will occur.
If I clone the repository locally and run it on a local file, it will run fine.

$ deno run -A https://deno.land/x/[email protected]/examples/hello.ts
error: Uncaught TypeError: Must be a file URL.
    throw new TypeError("Must be a file URL.");
          ^
    at fromFileUrl (https://deno.land/[email protected]/path/win32.ts:962:11)
    at carol.ts:46:27

Possible cause

I think this is because the Url obtained by import.meta.url is the https: protocol, and the Url of the https: protocol is passed as an argument to the fromFileUrl function.

• https://deno.land/x/[email protected]/carol.ts#L46

const __dirname = dirname(fromFileUrl(import.meta.url));

• https://deno.land/[email protected]/path/win32.ts#L959

export function fromFileUrl(url: string | URL): string {
  url = url instanceof URL ? url : new URL(url);
  if (url.protocol != "file:") {
    throw new TypeError("Must be a file URL.");
  }

environment

os : windows 10
deno : 1.6.3
carol : 1.0.0 (Same for 0.2.0 and 0.2.1)

error: Expected ';', '}' or at https://unpkg.com/[email protected]/lib/esm/puppeteer/common/ExecutionContext.js:1:16

There is another issue suggesting the use of deno-puppeteer, this could be related...

I tested it manually on my local machine, but I haven't written the test code yet.
Once denoland/deno#5973 is landed, I'll add tests for it.

Hello,

is it possible to keep the original window title, which was set during launch?
When I use the load method to dynamically load web pages, the window title changes with the change of the loaded pages.

Thanks

Hello, I've tried to use this great lib inside a compile deno binary, but I receive the following error:

error: TypeError: Self-contained binaries don't support module loading
    at async getWebSocketTransportClass (file://$deno$/bundle.js:9371:99)
    at async connectToBrowser (file://$deno$/bundle.js:9383:32)
    at async launch (file://$deno$/bundle.js:9483:22)
    at async launch1 (file://$deno$/bundle.js:11182:72)
    at async file://$deno$/bundle.js:11221:13

Also tried it with ./examples/hello.ts with same results.

Please, is there a way this could be fixed somehow?

Thanks,
Rado

https://github.com/lucacasonato/deno-puppeteer

https://github.com/berstend/puppeteer-extra