uga-libraries / web-download Goto Github PK

When wget returns an error code of 8, it means that a PDF file has been created with the indicated name but that the file was not in fact downloaded. This makes it look like the download was a success, but if the file is clicked on, it cannot be opened. Therefore, the PDF should be deleted if wget has an error code of 8.

PySimpleGUI has added an annual cost. MAGIL confirmed that they can operate the script from the command line instead.

Currently, make_seed_folder() changes the current directory to the seed folder, so PDFs can be saved to the current directory. This has caused problems with other scripts during testing where it is unclear what the directory should be for a valid test.

Include the seed folder as part of the path for saving the PDF so that the current directory is not important.

For now, while we aren't changing the script, having manual testing instructions is sufficient. If we begin more active development, start by making unit tests for all of the functions.

Challenge: the script is accessing the most recent crawl of the websites, so we need to update the test input each time for ones that are using the Archive-It API. The websites would be the same, but the files would not be.

Installing wget on MAGIL workstations was complicated due to them not having administrator access to their machines. Using the python requests or urllib libraries might be simpler.

Script tests if each of the arguments is present and an expected value. If it is possible with threading, doing this in a function would make for simpler code and make it easier to test.