Comments (4)
Hi @hanase ,
Thanks for pointing this out. We have changed _lookup_parking_cfg( )
in a branch called fixes_months_calculation
, so that actual parcel sizes are taken into account when calculating construction months.
@hanase, @janowicz: please take a look at https://github.com/UDST/developer/compare/fixes_months_calculation, and let me know if you have any questions or suggestions before creating a PR.
Thanks!!
Jessica
from developer.
Hi @jessicacamacho , thanks for looking into this!
It looks to me like the computation of month_values is not correct. The self.construction_months object is a matrix with columns corresponding to uses and rows corresponding to months (created here), so it's not form-specific.
from developer.
Hi @hanase,
Thanks for your comment. I have made a modification that should solve it, weighting the construction_months
values by use
(from proforma.yaml
) with the percentage of each use
on each form
:
developer/developer/sqftproforma.py
Lines 696 to 698 in 9f3d8eb
Please let me know if you have any additional suggestions or questions.
Thanks!
Jessica
from developer.
This works and gives the same results for different values of parcel_sizes. Thanks @jessicacamacho !
My suggestion would be to remove the need to have the parcel_sizes settings in the yaml file as it is quite confusing. Without reading the code one would not know that this setting has no impact on anything.
from developer.
Related Issues (20)
- Read user-configured projects HOT 4
- Design Proposal: Absorption Feedback into Feasibility HOT 1
- Create developments based on user-configured development projects. HOT 4
- Parcel Splitter HOT 2
- Parcels Aggregator HOT 1
- Pipeline Adder HOT 2
- Constructor Model HOT 1
- Basic market research model with absorption HOT 1
- Basic financing mechanism HOT 3
- Better exit condition handling in developer model HOT 1
- Remove 'year_built' assignment in developer
- Pro forma / developer logs
- Generalize `max_height` ProForma attributes
- Bug in computing max profit over all forms HOT 2
- A value is trying to be set on a copy of a slice from a DataFrame HOT 3
- Fix deploy keys for Travis CI
- Relax constraint of max FAR being below 20 HOT 1
- _select_buildings() fails when self.target_units is pd.DataFrame
- Fix failing Travis tests
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from developer.