ucsf-ighs / openmrs-esm-ohri Goto Github PK

Associated to the Continuous Deployment Ticket.
https://ohri.atlassian.net/jira/software/projects/OHRI/boards/1?selectedIssue=OHRI-90

The Continuos Deployment Trigger Runs and the Server Build is Udpated.

To fulfill this Pipeline Setup we had to skip 2 Build Tasks

• npm run typscript
• npm run coverage

Associated to the Continuous Deployment Ticket.
https://ohri.atlassian.net/jira/software/projects/OHRI/boards/1?selectedIssue=OHRI-90

The Continuous Deployment Trigger Runs and the Server Build is Updated.

To fulfill this Pipeline Setup we had to skip 2 Build Tasks

• npm run typescript
• npm run coverage

We need to fix the below ERROR

While Issuing a PR, as a Team to ensure proper documentation and best practices. Follow the below Check List
What is the Scope of the PR

• Include Screenshots or GIFs of the UI changes ?
• Link to the Issue (eg: at https:https://ohri.atlassian.net/jira/software/projects/OHRI/boards/1?selectedIssue=OHRI-)
• Bug fix (non-breaking change which fixes an issue, please reference the issue id)
• New feature (non-breaking change which adds functionality, make sure to open an associated issue first)
• All new and existing tests passed

Did you?

• Breaking change (fix or feature that would cause existing functionality to change)
• I have updated the documentation accordingly
• I have added tests to cover my changes

Collaboration

• Assign 2+ colleagues to your PR
• Ensure the CI Checks Pass before Merge
• Follow up with updating the Ticket associated to the Task

Feature Work

• Form Engine (Parity with Angular form engine)
  • Support rendering type "drug"
  • Ability to mark a form field as transient.
  • Support injecting of external data sources.
  • Support registration of custom expressions.
  • Support for creation of reusable components.
  • Support for rendering problem by concept class.
  • Support for file attachment rendering.
  • Concept location support.
  • Adjust the rest-web-services module to allow filtering of voided forms.
  • Form submission should use the form_uuid and encounter_uuid fetched from the backend.
  • Support for Z function as part of inbuilt Expression helpers.
  • Support translation/localisation (i18n) in labels.
  • Support for Drug Orders.
• Form Builder
  • Display of Audit information on the form editor.
  • Support for referencing reusable components.
• Mamba ETL
  • Move MambaETL DB flattening Task scheduler to base module.
  • Support for flattening concepts rendered as both questions and answers.
  • A configurable toggle between storing ETL output in the OpenMRS database or in External database.
  • Ensure that reports data is available while ETL is running.
  • Incremental update of ETL based on underlying data changes.
  • Automate addition of Make Scripts in MambaETL.
  • Service/API layer data pagination support in MambaETL.
  • Automate column naming in the ETL flattened Tables.
  • ObsGroups support for MambaETL.
  • Publish Version 2.0 of MambaETL.

Bugs

• Mamba ETL
  • Fix build failure when reports.json configuration file is missing.
  • Concepts with multi-select values (e.g. key population) failing to flatten.
• Form Engine
  • Previous values are picked from old encounters.

House Keeping

• Form Engine
  • Update Form Engine Documentation.
  • Comparison of validation in RFE against AFE.
• Mamba ETL
  • Test report on MambaETL running on MySQL 8.
  • MambaETL documentation - v1.0.0.
  • Performance improvement during the flattening process.
  • Robust Error Handling in MambaETL.
  • Code cleanups and Refactors in MambaETL.

A Patient chart side nav from openmrs-org[LINK] has a linear hierarchy similar to the image below:

However, with OHRI we introduced a sub-menu dropdown with HIV being a dropdown with items (HIV, care and treatment, PMTCT) as shown below:

In an attempt to make the sub-menu dynamic we came up with this code snippets:

index.ts

extensions: [
      {
        id: 'hts-summary-dashboard',
        slot: 'patient-chart-dashboard-slot',
        load: getSyncLifecycle(createDashboardLink(dashboardMeta), options),
        meta: dashboardMeta,
        online: true,
        offline: true,
      },
....
]

dashboard.meta.tsx

export const createDashboardLink = db => {
  const DashboardLink: React.FC<{ basePath: string }> = ({ basePath }) => {
    return (
      <SideNavMenu title="HIV" className={styles.noMarker} defaultExpanded={true}>
        <SideNavMenuItem className={styles.currentNavItem} isActive href={`${basePath}/${db.name}`}>
          HTS{' '}
        </SideNavMenuItem>
        <SideNavMenuItem>Care and Treatment </SideNavMenuItem>
        <SideNavMenuItem> PMTCT </SideNavMenuItem>
      </SideNavMenu>
    );
  };
  return DashboardLink;
};

export const dashboardMeta = {
    name: 'hts-summary',
    slot: 'hts-summary-dashboard-slot',
    config: { columns: 1, type: 'grid' },
    title: 'HTS Sessions',
};

while this worked for a single submenu link at the time, it became an issue with the adding of hrefs dynamically by updating the files to this:

dashboard.meta.tsx

....
....
        <SideNavMenuItem className={styles.currentNavItem} isActive href={`${basePath}/${db.hts.name}`}>
          HTS{' '}
        </SideNavMenuItem><SideNavMenuItem href={`${basePath}/${db.careAndTreatment.name}`}>Care and Treatment </SideNavMenuItem>
....
....
export const dashboardMeta = {
  hts: {
    name: 'hts-summary',
    slot: 'hts-summary-dashboard-slot',
    config: { columns: 1, type: 'grid' },
    title: 'HTS Sessions',
  },
  careAndTreatment: {
    name: 'care-and-treatment',
    slot: 'care-and-treatment-dashboard-slot',
    config: { columns: 1, type: 'grid' },
    title: 'Service Enrollments',
  },
};

This would allow has constantly update the dashboardMeta to dynamically add actions to the menu but this wasn't the case. The links ended up overriding each other and in some cases duplicating.