ucl-pond / ebm Goto Github PK

I think the "stage_histogram" function has a minor bug. For a given class, the sum of its fractions across the assigned stages exceeds 1. I think this can be addressed by fixing the input "bins" parameter when calling the "ax.hist" function.

All docstrings need to be checked to make sure they make sense, and also that the strings reference the correct variable names as I switched from camelCase to under_scores in my variable naming conventions

Need to think about what functions need tests and then write them. These need to be checked against other versions of EBM code or against results calculated by hand.

Everything needs to be checked with Python 3.x to make sure that it both works and that it produces the same results as 2.7