ubports / ubuntu-download-manager Goto Github PK

Something is wrong with the logfile creation in download manager:

The files cannot be extracted from a tgz archive anymore since they also have invalid datetimes

I get this error when building on Arch GNU/Linux (amd64)

Unknown option 'qt'.
make[2]: *** [docs/qml/CMakeFiles/qmldoc.dir/build.make:58: docs/qml/CMakeFiles/qmldoc] Error 1
make[1]: *** [CMakeFiles/Makefile2:4153: docs/qml/CMakeFiles/qmldoc.dir/all] Error 2

The troubling options resides in docs/qml/CMakeLists.txt on line 6.

The issue is related to qdoc: /usr/bin/qdoc -qt=qt5

I get this warning when building on Arch GNU/Linux (amd64)

CMake Warning at tests/downloads/qml/CMakeLists.txt:90 (message):
  dbus-test-runner binary not found tests will be disabled

dbus-test-runner is installed and is in $PATH

This gets used a lot here and is scheduled to be removed with Qt 6 afaik.

When downloading a file with SingleDownload boolean properties downloading and downloadInProgress doesn't emit changed signals.

According to the docs settings extract will try to extract the file after download

    SingleDownload {
        id: download

        metadata: Metadata {
            extract: true 
        }
    }

when zip file is dowload I get the url but the zip file is deleted. And no extracted files

Download manager doesn't through any error? line 70? http://paste.ubuntu.com/p/FWTJNrz6VX/

https://paste.ubuntu.com/p/bgW8Kzq6J6/

Having SingleDownload{}

• Disconnect internet connection
• trigger download
• after having no network error i.e. NetworkError: 3 - Host [].org not found, cancel() the download

downloading = true (should be false)
downloadInProgress = true (should be true?)

I get this error while building on Arch GNU/Linux (amd64):

CMake Error at cmake/modules/FindGtest.cmake:18 (message):
  google-mock package not found

Gmock and Gtest are installed. Mir is able to detect their existence.

I assume that this commit in Mir canonical/mir@e7bbc0f introduced support for it.

Arch GNU/Linux, bionic branch

CMake Error at src/downloads/qml/CMakeLists.txt:33 (qt5_use_modules):
  Unknown CMake command "qt5_use_modules".

Download of content (i.e. images from web.telegram.org, «exported» images from photopea.com, etc) starts to download but content is not handled / accessible.

How to reproduce:

1. Go to photopea.com
2. open an image or create a blank project
3. File > export as > png and save
4. Choose Download
   Result:
   xxx-xxxx-xxxxx
   blob:https://www.photopea.com/xxx-xxxxx-xxxxx
   NetworkError: 301 - Protocol "blob" is unkonw

Expected result:
Let user to decide what to do with blob info

https://paste.ubuntu.com/p/xK6zvgy4B9/

When downloading a file with

import Ubuntu.DownloadManager 1.2

SingleDownload {
    id: single
}

property single.downloadInProgress is always false

/home/pmos/build/src/ubuntu-download-manager-6d1d305da3f6e9c3bfba278fb7268b80c48ef7fd/src/common/public/ubuntu/transfers/metadata.cpp: In member function 'QVariantMap Ubuntu::Transfers::Metadata::custom() const':
/home/pmos/build/src/ubuntu-download-manager-6d1d305da3f6e9c3bfba278fb7268b80c48ef7fd/src/common/public/ubuntu/transfers/metadata.cpp:217:48: error: 'QList<T> QMap<K, V>::values(const Key&) const [with Key = QString; T = QVariant]' is deprecated: Use QMultiMap for maps storing multiple values with the same key. [-Werror=deprecated-declarations]
  217 |             custom.insert(customKey, values(key)[0]);
      |                                                ^
In file included from /usr/include/QtCore/QMap:1,
                 from /home/pmos/build/src/ubuntu-download-manager-6d1d305da3f6e9c3bfba278fb7268b80c48ef7fd/src/common/public/ubuntu/transfers/metadata.h:22,
                 from /home/pmos/build/src/ubuntu-download-manager-6d1d305da3f6e9c3bfba278fb7268b80c48ef7fd/src/common/public/ubuntu/transfers/metadata.cpp:22:
/usr/include/QtCore/qmap.h:1356:10: note: declared here
 1356 | QList<T> QMap<Key, T>::values(const Key &key) const
      |          ^~~~~~~~~~~~
cc1plus: all warnings being treated as errors

I'll likely fix it quite soon

• Open Podbird
• Download an episode

-> The app crashes until rebooting the device

Tested on Arale and Vegeta Dev channel 2021-03-23

Logs: line 85? http://paste.ubuntu.com/p/QFVb9Dj7zj/

Downloading file with a SingleDownload{} element will add downloaded elements in ~/.local/share/ubuntu-download-manager/[App Name]/Downloads/ without a way of empty the directory