ubports / ubuntu-app-launch Goto Github PK

Currently any output of a push helper process is logged into a log file with the pattern untrusted-helper-push-helper:<unique_number>:<appid>.log
(At least seen on TELEports)
The issue here is that those files are never cleaned up by logrotate since they contain a unique number which makes logrotate think that those are indeed independent files.
So far it was not an issue since the push helpers of TELEports and Fluffychat did not log anything, but recently a Telegram server change made the pushhelper to log an error. Some users have hundreds of those files in their .cache directory, maybe even thousands.

If com.canonical.PropertyService is not available on the system, the following error appears in every app's log upon its close:

Error: GDBus.Error:org.freedesktop.DBus.Error.ServiceUnknown: The name com.canonical.PropertyService was not provided by any .service files

This is likely caused by the check for developer mode in the post-stop script of every job, which is used to see if the log should be kept or not: https://github.com/ubports/ubuntu-app-launch/search?q=com.canonical.propertyservice&unscoped_q=com.canonical.propertyservice

We might need to find a new way to store the "developer mode" switch so it can be accessed when the device does not have Android properties.

Same as ubports/unity-api#4

Now fails to build on Arch, bionic branch:

In file included from /home/vanyasem/Projects/AUR/_Unity8/_Unity8-Arch/ubuntu-app-launch-git/src/ubuntu-app-launch/libubuntu-app-launch/ubuntu-app-launch.cpp:42:
/usr/include/unity/util/GlibMemory.h:213:1: error: redefinition of 'struct unity::util::internal::GlibDeleter<char>'
 UNITY_UTIL_DEFINE_GLIB_SMART_POINTERS(gchar, g_free)
 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/glib-2.0/glib/glib-autocleanups.h:90:1: note: previous definition of 'struct unity::util::internal::GlibDeleter<char>'
 G_DEFINE_AUTOPTR_CLEANUP_FUNC (GRefString, g_ref_string_release)
 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /home/vanyasem/Projects/AUR/_Unity8/_Unity8-Arch/ubuntu-app-launch-git/src/ubuntu-app-launch/libubuntu-app-launch/ubuntu-app-launch.cpp:42:
/usr/include/unity/util/GlibMemory.h:213:1: error: redefinition of 'struct unity::util::internal::GlibDeleter<char>'
 UNITY_UTIL_DEFINE_GLIB_SMART_POINTERS(gchar, g_free)
 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/glib-2.0/glib/glib-autocleanups.h:90:1: note: previous definition of 'struct unity::util::internal::GlibDeleter<char>'
 G_DEFINE_AUTOPTR_CLEANUP_FUNC (GRefString, g_ref_string_release)
 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~

This package depends on properties-cpp, but cmake doesn't check for it's existence

For newcomers, provide a quick Readme file to answer:

• What is the purpose of this repository ?
• How can i test / run ?
• How can i contribute ?
• How can i build and hack ?

sometimes it is helpful to start an app from terminal. (e.g. right now the libertine scope has issues and doesn't show icons)

it is possible to start from terminal, but it is a bit cumbersome, because of the non-intuitive appids

with the below completion script, one has autocompletion of app ids.

/usr/share/bash-completion/completions/ubuntu-app-launch

# -*- shell-script -*-

function _ubuntu-app-launch()
{
    local cur
    cur="${COMP_WORDS[COMP_CWORD]}"
    COMPREPLY=( $(compgen -W "$(ubuntu-app-launch-appids)" -- ${cur} ) )
} && complete -F _ubuntu-app-launch ubuntu-app-launch

It works if I copy it directly onto my device, but I don't really know where to stick it into the source code to have it packaged and installed.

This package fails to compile due to this bug: ubports/cmake-extras#2

Patching cmake-extras breaks the package and requires replacing GTEST_MAIN_LIBRARIES with GMOCK_LIBRARIES in tests/CMakeLists.txt

Currently there is a hard dependency on libertine and xmir, and libertine only supports creating an Ubuntu chroot on an Ubuntu system that is of the same release. This means anyone porting the Unity 8 stack to other distributions, must also build and ship libertine, even though it will not work.

Making libertine generic and usable on any distribution, and also support containers of those distributions, would be an extremely large amount of work. We should instead make libertine an optional dependency, so that we can still ship it on Ubuntu builds, but others can avoid it. As Xmir will eventually be replaced by Xwayland, this would also be a step toward supporting that.

For postmarketOS we will need a separate implementation for libubuntu-app-launch/jobs-systemd.{cpp,h}

From discussion : ubports/unity8#216

We need to provide a default icon when anything went wrong when loading app icon. Seems to be here for implementing it: https://github.com/ubports/ubuntu-app-launch/blob/xenial/libubuntu-app-launch/application-icon-finder.cpp#L73