ubports / ubports-api-node-module Goto Github PK

We share so much with the system-image module, it'd be a good idea to merge these. See ubports/system-image-node-module#19

I would like to discuss the possibility of an unreachable statement in the http module:

class HttpApi {
  constructor(options) {
    if (options) {
...
    }
// What I'm interested in discussing:
    if (!this.host)
      throw Error("Host option is required.");
  }

This is line 38 of the file. When can this be reached if there no possibility of creating an empty HttpApi object? Even when we do new HttpApi({host: ""}) it will return the previous error defined with invalid host url.
If you can help me understand when this if statement is reached, I can potentially add one more test to it to make sure this line is covered.

Thanks in advance for your help.

JSDoc blocks should be added to all our functions.

Properly detect timeouts! Allow to specify timeout time.

We just had an unnoticed multiple-hour-long outage of the api that broke the installer and devices page. We could mediate that risk by allowing to specify an array of alternative data sources.

Someone posted a screenshot of the UT installer with the selectable devices list expanded in the German UT telegram group.
And with 14 unsorted elements it's already now a little inconvenient to find the correct entry.

I'd prefer that list to be ordered alphabetically.