typo3 / crowdin-bridge Goto Github PK

as discussed in the l10n team

There are labels which are not exported from Crowdin to the zip files which are stored on localize.typo3.org.

Example:

• Identifier (Key): pages.canonical_link.description
• Source XLF File: EXT:seo/Resources/Private/Language/locallang_tca.xlf
• Crowdin translation: https://crowdin.com/editor/typo3-cms/1172/en-de?view=comfortable&filter=basic&value=3#q=pages.canonical_link.description

In the ZIP file the mentioned identifier ist missing:
https://localize.typo3.org/xliff/s/e/seo-l10n/seo-l10n-de.v12.zip

When you download the ZIP file which is built by Crowdin directly, the translation can be found in main/typo3/sysext/seo/Resources/Private/Language/de.locallang_tca.xlf

The language label pages.canonical_link.description was introduced with this commit:
TYPO3/typo3@79683d6

The first version of TYPO3 containing that label was 12.4.6:
https://get.typo3.org/release-notes/12.4.6

The label is included in TYPO3 13.1.0. The problem therefore "only" affects TYPO3 v12.

I assume the problem is within our Crowdin Bridge. Maybe the problem is, that the new label was introduced after the official LTS release?

Issue description

Current core main cannot download language packs. (Which is silently hidden). But checking the log, you could see the following for example:

Thu, 16 Jun 2022 20:06:46 +0200 [WARNING] request="13c0c32a6b4f6" component="TYPO3.CMS.Install.Service.LanguagePackService": Requesting https://localize.typo3.org/xliff/b/a/backend-l10n/backend-l10n-de.v12.zip was not successful, got status code 404 (Not Found) - {"request":"https://localize.typo3.org/xliff/b/a/backend-l10n/backend-l10n-de.v12.zip","status":404,"reason":"Not Found"}

It tries to downloade a languge file with v12 in the uri, which seams not to exists:
https://localize.typo3.org/xliff/b/a/backend-l10n/backend-l10n-de.v12.zip

Opend in browser it displays following

Looked up on crowed in, there are 9.5, 10.4 and main branch - 11.5 is here missing at all.
I would guess that 11.5 branch may have to be added here as a first step ? And then doing some changes, like stated below ?

Thoughts/Suggestion

1. Create 11.5 branch on crowedin (copy over translations from "main" ?)

2. Not sure, but just from reading code on github maybe we should add here 12 as first version number:
   

   crowdin-bridge/src/Info/CoreInformation.php

   Line 22 in a9e0769

   private const VERSIONS = [11, 10, 9];

3. followed by adding here 11 => '11.5', at the top:
   

   crowdin-bridge/src/Info/CoreInformation.php

   Line 28 in a9e0769

   10 => '10.4',

If I read the code correct, "main" should than switch and create the zip for "v12", and the "v11" zipfile based on the 11.5 branch (if configured as branch on crowedin).

For some extensions it happens that tha language file download goes into a master subfolder.

E.g:
/typo3conf/l10n/de/static_info_tables_taxes/master/

It should have been here:
/typo3conf/l10n/de/static_info_tables_taxes/

This happens for the following extensions:

static_info_tables_taxes
watchwords

The same error has been with tt_products for a long time. But now the download of tt_products is in the correct path. However all translation files are not downloaded any more.

Since scheduled GitHub actions in public repositories are automatically stopped when there is no activity in the repository for the last 60 days (see https://docs.github.com/en/actions/reference/usage-limits-billing-and-administration), we need to monitor if GitHub action run as expected.

Maybe it is possible to add a check for this to https://status.typo3.org/