Coder Social home page Coder Social logo

Comments (2)

KunalSalunkhe12 avatar KunalSalunkhe12 commented on April 28, 2024

@branislav-brincko
The reason for this is that the | operator in TypeScript denotes a union of types, which means that a value of type Props1 | Props2 can be either of type Props1 or Props2. So if you pass both foo and bar props to MyComponent when it is expecting a value of type Props1 | Props2, TypeScript does not consider it an error because it still matches the type Props1 | Props2

One solution might be to add one more condition

if ("foo" in props && "bar" in props) {
    throw new Error("MyComponent expects only one of foo or bar props");
  }

from react.

gajjardarshithasmukhbhai avatar gajjardarshithasmukhbhai commented on April 28, 2024

@branislav-brincko The reason for this is that the | operator in TypeScript denotes a union of types, which means that a value of type Props1 | Props2 can be either of type Props1 or Props2. So if you pass both foo and bar props to MyComponent when it is expecting a value of type Props1 | Props2, TypeScript does not consider it an error because it still matches the type Props1 | Props2

One solution might be to add one more condition

if ("foo" in props && "bar" in props) {
    throw new Error("MyComponent expects only one of foo or bar props");
  }

@KunalSalunkhe12 But I have doubt here, let's say If we have dynamic props instead of foo and bar. so I think that time we need to mention in different props. But we can achieve above thing by below snippets

type Props<T extends keyof any> = {
  [K in T]: string;
};

function MyComponent<T extends keyof any>(props: Props<T>) {
  return <div>{props[Object.keys(props)[0] as T]}</div>;
}

const UsageComponent = () => (
  <div>
    <MyComponent foo="foo" />
    <MyComponent bar="bar" />
  </div>
);

so in the above snippets, I am getting dynamic keys from the props and mentioned to the string. so we can leverage to mention different props without second, thought!

please correct me if I am wrong.

CC: @branislav-brincko

from react.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.